| Message ID | 20230418114506.46788-2-ilpo.jarvinen@linux.intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | selftests/resctrl: Fixes, cleanups, and rewritten CAT test | expand |
Hi Ilpo, On 4/18/2023 4:44 AM, Ilpo Järvinen wrote: > Makefile only lists *.c as build dependecies for the restctrl_tests dependecies -> dependencies restctrl_tests -> resctrl_tests > executable which excludes resctrl.h. > > Add *.h to wildcard() cover also resctrl.h. I find this a bit hard to parse. How about "Add *.h to wildcard() to include resctrl.h." (considering the problem statement indicates that resctrl.h was "excluded", having it now "included" seems to match) > > Fixes: 591a6e8588fc ("selftests/resctrl: Add basic resctrl file system operations and data") > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > --- > tools/testing/selftests/resctrl/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/resctrl/Makefile b/tools/testing/selftests/resctrl/Makefile > index 73d53257df42..2dc7da221795 100644 > --- a/tools/testing/selftests/resctrl/Makefile > +++ b/tools/testing/selftests/resctrl/Makefile > @@ -7,4 +7,4 @@ TEST_GEN_PROGS := resctrl_tests > > include ../lib.mk > > -$(OUTPUT)/resctrl_tests: $(wildcard *.c) > +$(OUTPUT)/resctrl_tests: $(wildcard *.c *.h) How about a simpler *.[ch]? Seems like this pattern is popular in selftest code. Reinette
diff --git a/tools/testing/selftests/resctrl/Makefile b/tools/testing/selftests/resctrl/Makefile index 73d53257df42..2dc7da221795 100644 --- a/tools/testing/selftests/resctrl/Makefile +++ b/tools/testing/selftests/resctrl/Makefile @@ -7,4 +7,4 @@ TEST_GEN_PROGS := resctrl_tests include ../lib.mk -$(OUTPUT)/resctrl_tests: $(wildcard *.c) +$(OUTPUT)/resctrl_tests: $(wildcard *.c *.h)
Makefile only lists *.c as build dependecies for the restctrl_tests executable which excludes resctrl.h. Add *.h to wildcard() cover also resctrl.h. Fixes: 591a6e8588fc ("selftests/resctrl: Add basic resctrl file system operations and data") Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> --- tools/testing/selftests/resctrl/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)