| Message ID | 20230427-hammerhead-vibra-v1-2-e87eeb94da51@z3ntu.xyz |
|---|---|
| State | Accepted |
| Commit | 29ebf697f18d9eeaa8d53c7bd16c4e6962508019 |
| Headers | show |
| Series | Add haptics support to Nexus 5 using pwm-vibra driver | expand |
On Thu, Apr 27, 2023 at 10:34:27PM +0200, Luca Weiss wrote: > Make sure all printed messages end with a newline. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> Reviewed-by: Brian Masney <bmasney@redhat.com>
On 27/04/2023 21:34, Luca Weiss wrote: > Make sure all printed messages end with a newline. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org> > --- > drivers/input/misc/pwm-vibra.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/input/misc/pwm-vibra.c b/drivers/input/misc/pwm-vibra.c > index d0e58a7cdfa3..c08971c97ad6 100644 > --- a/drivers/input/misc/pwm-vibra.c > +++ b/drivers/input/misc/pwm-vibra.c > @@ -42,7 +42,7 @@ static int pwm_vibrator_start(struct pwm_vibrator *vibrator) > if (!vibrator->vcc_on) { > err = regulator_enable(vibrator->vcc); > if (err) { > - dev_err(pdev, "failed to enable regulator: %d", err); > + dev_err(pdev, "failed to enable regulator: %d\n", err); > return err; > } > vibrator->vcc_on = true; > @@ -54,7 +54,7 @@ static int pwm_vibrator_start(struct pwm_vibrator *vibrator) > > err = pwm_apply_state(vibrator->pwm, &state); > if (err) { > - dev_err(pdev, "failed to apply pwm state: %d", err); > + dev_err(pdev, "failed to apply pwm state: %d\n", err); > return err; > } > > @@ -65,7 +65,7 @@ static int pwm_vibrator_start(struct pwm_vibrator *vibrator) > > err = pwm_apply_state(vibrator->pwm_dir, &state); > if (err) { > - dev_err(pdev, "failed to apply dir-pwm state: %d", err); > + dev_err(pdev, "failed to apply dir-pwm state: %d\n", err); > pwm_disable(vibrator->pwm); > return err; > } > @@ -137,7 +137,7 @@ static int pwm_vibrator_probe(struct platform_device *pdev) > err = PTR_ERR_OR_ZERO(vibrator->vcc); > if (err) { > if (err != -EPROBE_DEFER) > - dev_err(&pdev->dev, "Failed to request regulator: %d", > + dev_err(&pdev->dev, "Failed to request regulator: %d\n", > err); > return err; > } > @@ -146,7 +146,7 @@ static int pwm_vibrator_probe(struct platform_device *pdev) > err = PTR_ERR_OR_ZERO(vibrator->pwm); > if (err) { > if (err != -EPROBE_DEFER) > - dev_err(&pdev->dev, "Failed to request main pwm: %d", > + dev_err(&pdev->dev, "Failed to request main pwm: %d\n", > err); > return err; > } > @@ -158,7 +158,7 @@ static int pwm_vibrator_probe(struct platform_device *pdev) > state.enabled = false; > err = pwm_apply_state(vibrator->pwm, &state); > if (err) { > - dev_err(&pdev->dev, "failed to apply initial PWM state: %d", > + dev_err(&pdev->dev, "failed to apply initial PWM state: %d\n", > err); > return err; > } > @@ -172,7 +172,7 @@ static int pwm_vibrator_probe(struct platform_device *pdev) > state.enabled = false; > err = pwm_apply_state(vibrator->pwm_dir, &state); > if (err) { > - dev_err(&pdev->dev, "failed to apply initial PWM state: %d", > + dev_err(&pdev->dev, "failed to apply initial PWM state: %d\n", > err); > return err; > } > @@ -189,7 +189,7 @@ static int pwm_vibrator_probe(struct platform_device *pdev) > break; > > default: > - dev_err(&pdev->dev, "Failed to request direction pwm: %d", err); > + dev_err(&pdev->dev, "Failed to request direction pwm: %d\n", err); > fallthrough; > > case -EPROBE_DEFER: > @@ -207,13 +207,13 @@ static int pwm_vibrator_probe(struct platform_device *pdev) > err = input_ff_create_memless(vibrator->input, NULL, > pwm_vibrator_play_effect); > if (err) { > - dev_err(&pdev->dev, "Couldn't create FF dev: %d", err); > + dev_err(&pdev->dev, "Couldn't create FF dev: %d\n", err); > return err; > } > > err = input_register_device(vibrator->input); > if (err) { > - dev_err(&pdev->dev, "Couldn't register input dev: %d", err); > + dev_err(&pdev->dev, "Couldn't register input dev: %d\n", err); > return err; > } > >
Hi, On Thu, Apr 27, 2023 at 10:34:27PM +0200, Luca Weiss wrote: > Make sure all printed messages end with a newline. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- Reviewed-by: Sebastian Reichel <sre@kernel.org> -- Sebastian > drivers/input/misc/pwm-vibra.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/input/misc/pwm-vibra.c b/drivers/input/misc/pwm-vibra.c > index d0e58a7cdfa3..c08971c97ad6 100644 > --- a/drivers/input/misc/pwm-vibra.c > +++ b/drivers/input/misc/pwm-vibra.c > @@ -42,7 +42,7 @@ static int pwm_vibrator_start(struct pwm_vibrator *vibrator) > if (!vibrator->vcc_on) { > err = regulator_enable(vibrator->vcc); > if (err) { > - dev_err(pdev, "failed to enable regulator: %d", err); > + dev_err(pdev, "failed to enable regulator: %d\n", err); > return err; > } > vibrator->vcc_on = true; > @@ -54,7 +54,7 @@ static int pwm_vibrator_start(struct pwm_vibrator *vibrator) > > err = pwm_apply_state(vibrator->pwm, &state); > if (err) { > - dev_err(pdev, "failed to apply pwm state: %d", err); > + dev_err(pdev, "failed to apply pwm state: %d\n", err); > return err; > } > > @@ -65,7 +65,7 @@ static int pwm_vibrator_start(struct pwm_vibrator *vibrator) > > err = pwm_apply_state(vibrator->pwm_dir, &state); > if (err) { > - dev_err(pdev, "failed to apply dir-pwm state: %d", err); > + dev_err(pdev, "failed to apply dir-pwm state: %d\n", err); > pwm_disable(vibrator->pwm); > return err; > } > @@ -137,7 +137,7 @@ static int pwm_vibrator_probe(struct platform_device *pdev) > err = PTR_ERR_OR_ZERO(vibrator->vcc); > if (err) { > if (err != -EPROBE_DEFER) > - dev_err(&pdev->dev, "Failed to request regulator: %d", > + dev_err(&pdev->dev, "Failed to request regulator: %d\n", > err); > return err; > } > @@ -146,7 +146,7 @@ static int pwm_vibrator_probe(struct platform_device *pdev) > err = PTR_ERR_OR_ZERO(vibrator->pwm); > if (err) { > if (err != -EPROBE_DEFER) > - dev_err(&pdev->dev, "Failed to request main pwm: %d", > + dev_err(&pdev->dev, "Failed to request main pwm: %d\n", > err); > return err; > } > @@ -158,7 +158,7 @@ static int pwm_vibrator_probe(struct platform_device *pdev) > state.enabled = false; > err = pwm_apply_state(vibrator->pwm, &state); > if (err) { > - dev_err(&pdev->dev, "failed to apply initial PWM state: %d", > + dev_err(&pdev->dev, "failed to apply initial PWM state: %d\n", > err); > return err; > } > @@ -172,7 +172,7 @@ static int pwm_vibrator_probe(struct platform_device *pdev) > state.enabled = false; > err = pwm_apply_state(vibrator->pwm_dir, &state); > if (err) { > - dev_err(&pdev->dev, "failed to apply initial PWM state: %d", > + dev_err(&pdev->dev, "failed to apply initial PWM state: %d\n", > err); > return err; > } > @@ -189,7 +189,7 @@ static int pwm_vibrator_probe(struct platform_device *pdev) > break; > > default: > - dev_err(&pdev->dev, "Failed to request direction pwm: %d", err); > + dev_err(&pdev->dev, "Failed to request direction pwm: %d\n", err); > fallthrough; > > case -EPROBE_DEFER: > @@ -207,13 +207,13 @@ static int pwm_vibrator_probe(struct platform_device *pdev) > err = input_ff_create_memless(vibrator->input, NULL, > pwm_vibrator_play_effect); > if (err) { > - dev_err(&pdev->dev, "Couldn't create FF dev: %d", err); > + dev_err(&pdev->dev, "Couldn't create FF dev: %d\n", err); > return err; > } > > err = input_register_device(vibrator->input); > if (err) { > - dev_err(&pdev->dev, "Couldn't register input dev: %d", err); > + dev_err(&pdev->dev, "Couldn't register input dev: %d\n", err); > return err; > } > > > -- > 2.40.0 >
diff --git a/drivers/input/misc/pwm-vibra.c b/drivers/input/misc/pwm-vibra.c index d0e58a7cdfa3..c08971c97ad6 100644 --- a/drivers/input/misc/pwm-vibra.c +++ b/drivers/input/misc/pwm-vibra.c @@ -42,7 +42,7 @@ static int pwm_vibrator_start(struct pwm_vibrator *vibrator) if (!vibrator->vcc_on) { err = regulator_enable(vibrator->vcc); if (err) { - dev_err(pdev, "failed to enable regulator: %d", err); + dev_err(pdev, "failed to enable regulator: %d\n", err); return err; } vibrator->vcc_on = true; @@ -54,7 +54,7 @@ static int pwm_vibrator_start(struct pwm_vibrator *vibrator) err = pwm_apply_state(vibrator->pwm, &state); if (err) { - dev_err(pdev, "failed to apply pwm state: %d", err); + dev_err(pdev, "failed to apply pwm state: %d\n", err); return err; } @@ -65,7 +65,7 @@ static int pwm_vibrator_start(struct pwm_vibrator *vibrator) err = pwm_apply_state(vibrator->pwm_dir, &state); if (err) { - dev_err(pdev, "failed to apply dir-pwm state: %d", err); + dev_err(pdev, "failed to apply dir-pwm state: %d\n", err); pwm_disable(vibrator->pwm); return err; } @@ -137,7 +137,7 @@ static int pwm_vibrator_probe(struct platform_device *pdev) err = PTR_ERR_OR_ZERO(vibrator->vcc); if (err) { if (err != -EPROBE_DEFER) - dev_err(&pdev->dev, "Failed to request regulator: %d", + dev_err(&pdev->dev, "Failed to request regulator: %d\n", err); return err; } @@ -146,7 +146,7 @@ static int pwm_vibrator_probe(struct platform_device *pdev) err = PTR_ERR_OR_ZERO(vibrator->pwm); if (err) { if (err != -EPROBE_DEFER) - dev_err(&pdev->dev, "Failed to request main pwm: %d", + dev_err(&pdev->dev, "Failed to request main pwm: %d\n", err); return err; } @@ -158,7 +158,7 @@ static int pwm_vibrator_probe(struct platform_device *pdev) state.enabled = false; err = pwm_apply_state(vibrator->pwm, &state); if (err) { - dev_err(&pdev->dev, "failed to apply initial PWM state: %d", + dev_err(&pdev->dev, "failed to apply initial PWM state: %d\n", err); return err; } @@ -172,7 +172,7 @@ static int pwm_vibrator_probe(struct platform_device *pdev) state.enabled = false; err = pwm_apply_state(vibrator->pwm_dir, &state); if (err) { - dev_err(&pdev->dev, "failed to apply initial PWM state: %d", + dev_err(&pdev->dev, "failed to apply initial PWM state: %d\n", err); return err; } @@ -189,7 +189,7 @@ static int pwm_vibrator_probe(struct platform_device *pdev) break; default: - dev_err(&pdev->dev, "Failed to request direction pwm: %d", err); + dev_err(&pdev->dev, "Failed to request direction pwm: %d\n", err); fallthrough; case -EPROBE_DEFER: @@ -207,13 +207,13 @@ static int pwm_vibrator_probe(struct platform_device *pdev) err = input_ff_create_memless(vibrator->input, NULL, pwm_vibrator_play_effect); if (err) { - dev_err(&pdev->dev, "Couldn't create FF dev: %d", err); + dev_err(&pdev->dev, "Couldn't create FF dev: %d\n", err); return err; } err = input_register_device(vibrator->input); if (err) { - dev_err(&pdev->dev, "Couldn't register input dev: %d", err); + dev_err(&pdev->dev, "Couldn't register input dev: %d\n", err); return err; }
Make sure all printed messages end with a newline. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- drivers/input/misc/pwm-vibra.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)