diff mbox

[ARM] Fix PR target/53440 - handle generic thunks better for TARGET_32BIT.

Message ID CAKdteOZTAjJoBk1ZB6FnPC-iLTh6LD2-bhPYWuTnpdTjpBnwAQ@mail.gmail.com
State New
Headers show

Commit Message

Christophe Lyon May 17, 2016, 12:25 p.m. UTC 
On 1 April 2016 at 17:32, Ramana Radhakrishnan
<ramana.radhakrishnan@foss.arm.com> wrote:
> I've had this in my tree for a few months now but never got

> around to submitting it.

>

> This partially fixes PR target/53440 atleast in ARM and

> Thumb2 state. I haven't yet managed to get my head around

> rewriting the Thumb1 support yet.

>

> Tested on armhf with a bootstrap and regression test

> with no regressions.

>


Hi Ramana,

It took me a while to understand why the test was failing on a Thumb1 target
despite the dg-skip directive.
The problem was that dg-do was after dg-skip.

I've checked in the swap, I hope it is "obvious" enough.

Christophe.

> Queued for stage1 now as it isn't technically a regression.

>

> regards

> Ramana

>

>

> <DATE>  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>

>

>         PR target/53440

>         * config/arm/arm.c (arm32_output_mi_thunk): New.

>         (arm_output_mi_thunk): Rename to arm_thumb1_mi_thunk. Rework

>         to split Thumb1 vs TARGET_32BIT functionality.

>         (arm_thumb1_mi_thunk): New.

>

>

>         * g++.dg/inherit/thunk1.C: Support arm / aarch64.
diff mbox

Patch

Index: gcc/testsuite/ChangeLog
===================================================================
--- gcc/testsuite/ChangeLog	(revision 236318)
+++ gcc/testsuite/ChangeLog	(revision 236319)
@@ -1,3 +1,7 @@ 
+2016-05-17  Christophe Lyon  <christophe.lyon@linaro.org>
+
+	* g++.dg/inherit/think1.C: Fix dg-do and dg-skip order.
+
 2016-05-17  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
 
 	PR target/70809
Index: gcc/testsuite/g++.dg/inherit/thunk1.C
===================================================================
--- gcc/testsuite/g++.dg/inherit/thunk1.C	(revision 236318)
+++ gcc/testsuite/g++.dg/inherit/thunk1.C	(revision 236319)
@@ -1,5 +1,5 @@ 
+// { dg-do run { target arm*-*-* aarch64*-*-* i?86-*-* x86_64-*-* s390*-*-* alpha*-*-* ia64-*-* sparc*-*-* } }
 // { dg-skip-if "" { arm_thumb1_ok } }
-// { dg-do run { target arm*-*-* aarch64*-*-* i?86-*-* x86_64-*-* s390*-*-* alpha*-*-* ia64-*-* sparc*-*-* } }
 
 #include <stdarg.h>