| Message ID | 20230509-ocmem-hwver-v1-1-b83ece3f2168@z3ntu.xyz |
|---|---|
| State | New |
| Headers | show |
| Series | soc: qcom: ocmem: Add OCMEM hardware version print | expand |
On 9.05.2023 23:26, Luca Weiss wrote: > It might be useful to know what hardware version of the OCMEM block the > SoC contains. Add a debug print for that. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > drivers/soc/qcom/ocmem.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/soc/qcom/ocmem.c b/drivers/soc/qcom/ocmem.c > index 199fe9872035..aa9b3c2c1322 100644 > --- a/drivers/soc/qcom/ocmem.c > +++ b/drivers/soc/qcom/ocmem.c > @@ -355,6 +355,10 @@ static int ocmem_dev_probe(struct platform_device *pdev) > } > } > > + reg = ocmem_read(ocmem, OCMEM_REG_HW_VERSION); > + dev_dbg(dev, "OCMEM hardware version: %ld.%ld.%ld\n", > + (reg >> 28) & 0x0F, (reg >> 16) & 0xFFF, reg & 0xFFFF); Would you mind wrapping this into #define REG_HW_VERSION_MAJ(ver) FIELD_GET(GENMASK(31, 28), ver) etc.? Konrad > + > reg = ocmem_read(ocmem, OCMEM_REG_HW_PROFILE); > ocmem->num_ports = OCMEM_HW_PROFILE_NUM_PORTS(reg); > ocmem->num_macros = OCMEM_HW_PROFILE_NUM_MACROS(reg); > > --- > base-commit: ac9a78681b921877518763ba0e89202254349d1b > change-id: 20230509-ocmem-hwver-99bcb33b028b > > Best regards,
diff --git a/drivers/soc/qcom/ocmem.c b/drivers/soc/qcom/ocmem.c index 199fe9872035..aa9b3c2c1322 100644 --- a/drivers/soc/qcom/ocmem.c +++ b/drivers/soc/qcom/ocmem.c @@ -355,6 +355,10 @@ static int ocmem_dev_probe(struct platform_device *pdev) } } + reg = ocmem_read(ocmem, OCMEM_REG_HW_VERSION); + dev_dbg(dev, "OCMEM hardware version: %ld.%ld.%ld\n", + (reg >> 28) & 0x0F, (reg >> 16) & 0xFFF, reg & 0xFFFF); + reg = ocmem_read(ocmem, OCMEM_REG_HW_PROFILE); ocmem->num_ports = OCMEM_HW_PROFILE_NUM_PORTS(reg); ocmem->num_macros = OCMEM_HW_PROFILE_NUM_MACROS(reg);
It might be useful to know what hardware version of the OCMEM block the SoC contains. Add a debug print for that. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- drivers/soc/qcom/ocmem.c | 4 ++++ 1 file changed, 4 insertions(+) --- base-commit: ac9a78681b921877518763ba0e89202254349d1b change-id: 20230509-ocmem-hwver-99bcb33b028b Best regards,