diff mbox

[2/2] qemu: command: Error on accel2d

Message ID a571d22953d37387f1b2e07aded38d1d16239cde.1463702668.git.crobinso@redhat.com
State Superseded
Headers show

Commit Message

Cole Robinson May 20, 2016, 12:07 a.m. UTC 
qemu doesn't have any accel2d support wired up. Explicitly error
if a user tries it out, or typos the accel3d option
---
 src/qemu/qemu_command.c | 6 ++++++
 1 file changed, 6 insertions(+)

-- 
2.7.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Comments

Cole Robinson May 20, 2016, 12:11 p.m. UTC | #1 
On 05/20/2016 03:22 AM, Gerd Hoffmann wrote:
> On Do, 2016-05-19 at 20:07 -0400, Cole Robinson wrote:

>> qemu doesn't have any accel2d support wired up. Explicitly error

>> if a user tries it out, or typos the accel3d option

> 

> Well, cirrus has 2d accel.  You can't turn it on or off though, so

> setting 2d accel=yes for cirrus would just be cosmetical.  Probably

> confusing too as 2d accel is pretty much unused these days.  I think

> Windows NT4 age software can and will use cirrus 2d blit ops.

> 


Interesting. Though WRT libvirt accel2d has only ever been an option supported
by the virtualbox drivers AFAIK. At least with this patch libvirt makes it
explicit that the accel2d setting isn't impacting config whatsoever

Thanks,
Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
diff mbox

Patch

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 731f4c0..cca59a6 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -4125,6 +4125,12 @@  qemuBuildDeviceVideoStr(const virDomainDef *def,
 
     virBufferAsprintf(&buf, "%s,id=%s", model, video->info.alias);
 
+    if (video->accel && video->accel->accel2d == VIR_TRISTATE_SWITCH_ON) {
+        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+                       _("qemu does not support the accel2d setting"));
+        goto error;
+    }
+
     if (video->accel && video->accel->accel3d == VIR_TRISTATE_SWITCH_ON) {
         if (video->type != VIR_DOMAIN_VIDEO_TYPE_VIRTIO ||
             !virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIRTIO_GPU_VIRGL)) {