diff mbox series

ACPI: FFH: Drop the inclusion of linux/arm-smccc.h

Message ID 20230605103536.2427428-1-sudeep.holla@arm.com
State Accepted
Commit 097e727b585a9031e04e5c883e02c05ee8c6c901
Headers show
Series ACPI: FFH: Drop the inclusion of linux/arm-smccc.h | expand

Commit Message

Sudeep Holla June 5, 2023, 10:35 a.m. UTC
The inclusion of linux/arm-smccc.h in acpi_ffh is unnecessary and can
be even termed wrong. It is needed in the arm64 architecture callback
implementation and probably is the leftover from the missed cleanup of
the initial implementation.

Cc: Rafael J. Wysocki <rafael@kernel.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 drivers/acpi/acpi_ffh.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Rafael J. Wysocki June 12, 2023, 5:29 p.m. UTC | #1
On Mon, Jun 5, 2023 at 12:35 PM Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> The inclusion of linux/arm-smccc.h in acpi_ffh is unnecessary and can
> be even termed wrong. It is needed in the arm64 architecture callback
> implementation and probably is the leftover from the missed cleanup of
> the initial implementation.
>
> Cc: Rafael J. Wysocki <rafael@kernel.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  drivers/acpi/acpi_ffh.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/acpi/acpi_ffh.c b/drivers/acpi/acpi_ffh.c
> index 19aff808bbb8..8d5126963dc7 100644
> --- a/drivers/acpi/acpi_ffh.c
> +++ b/drivers/acpi/acpi_ffh.c
> @@ -9,8 +9,6 @@
>  #include <linux/idr.h>
>  #include <linux/io.h>
>
> -#include <linux/arm-smccc.h>
> -
>  static struct acpi_ffh_info ffh_ctx;
>
>  int __weak acpi_ffh_address_space_arch_setup(void *handler_ctxt,
> --

Applied as 6.5 material, thanks!
diff mbox series

Patch

diff --git a/drivers/acpi/acpi_ffh.c b/drivers/acpi/acpi_ffh.c
index 19aff808bbb8..8d5126963dc7 100644
--- a/drivers/acpi/acpi_ffh.c
+++ b/drivers/acpi/acpi_ffh.c
@@ -9,8 +9,6 @@ 
 #include <linux/idr.h>
 #include <linux/io.h>
 
-#include <linux/arm-smccc.h>
-
 static struct acpi_ffh_info ffh_ctx;
 
 int __weak acpi_ffh_address_space_arch_setup(void *handler_ctxt,