| Message ID | 20230706161040.21152-3-henning.schild@siemens.com |
|---|---|
| State | New |
| Headers | show |
| Series | platform/x86: simatic-ipc: minor cleanups | expand |
On Thu, 06 Jul 2023, Henning Schild wrote: > This was found with giving the file to checkpatch. > > Signed-off-by: Henning Schild <henning.schild@siemens.com> > --- > drivers/leds/simple/simatic-ipc-leds-gpio.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.h b/drivers/leds/simple/simatic-ipc-leds-gpio.h > index bf258c32f83d..3d4877aa4e0c 100644 > --- a/drivers/leds/simple/simatic-ipc-leds-gpio.h > +++ b/drivers/leds/simple/simatic-ipc-leds-gpio.h > @@ -1,4 +1,4 @@ > -// SPDX-License-Identifier: GPL-2.0 > +/* SPDX-License-Identifier: GPL-2.0 */ What prompted this change? % git grep -F "// SPDX-License-Identifier:" -- drivers/leds | wc -l 117 % git grep -F "/* SPDX-License-Identifier:" -- drivers/leds | wc -l 2
Am Wed, 12 Jul 2023 12:52:52 +0100 schrieb Lee Jones <lee@kernel.org>: > On Thu, 06 Jul 2023, Henning Schild wrote: > > > This was found with giving the file to checkpatch. > > > > Signed-off-by: Henning Schild <henning.schild@siemens.com> > > --- > > drivers/leds/simple/simatic-ipc-leds-gpio.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.h > > b/drivers/leds/simple/simatic-ipc-leds-gpio.h index > > bf258c32f83d..3d4877aa4e0c 100644 --- > > a/drivers/leds/simple/simatic-ipc-leds-gpio.h +++ > > b/drivers/leds/simple/simatic-ipc-leds-gpio.h @@ -1,4 +1,4 @@ > > -// SPDX-License-Identifier: GPL-2.0 > > +/* SPDX-License-Identifier: GPL-2.0 */ > > What prompted this change? > > % git grep -F "// SPDX-License-Identifier:" -- drivers/leds | wc -l > 117 > % git grep -F "/* SPDX-License-Identifier:" -- drivers/leds | wc -l > 2 > ./scripts/checkpatch.pl --no-tree --file drivers/leds/simple/simatic-ipc-leds-gpio.h it boils down to header versus c-file, not sure why headers prefer that other style Henning
On Wed, 12 Jul 2023, Henning Schild wrote: > Am Wed, 12 Jul 2023 12:52:52 +0100 > schrieb Lee Jones <lee@kernel.org>: > > > On Thu, 06 Jul 2023, Henning Schild wrote: > > > > > This was found with giving the file to checkpatch. > > > > > > Signed-off-by: Henning Schild <henning.schild@siemens.com> > > > --- > > > drivers/leds/simple/simatic-ipc-leds-gpio.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.h > > > b/drivers/leds/simple/simatic-ipc-leds-gpio.h index > > > bf258c32f83d..3d4877aa4e0c 100644 --- > > > a/drivers/leds/simple/simatic-ipc-leds-gpio.h +++ > > > b/drivers/leds/simple/simatic-ipc-leds-gpio.h @@ -1,4 +1,4 @@ > > > -// SPDX-License-Identifier: GPL-2.0 > > > +/* SPDX-License-Identifier: GPL-2.0 */ > > > > What prompted this change? > > > > % git grep -F "// SPDX-License-Identifier:" -- drivers/leds | wc -l > > 117 > > % git grep -F "/* SPDX-License-Identifier:" -- drivers/leds | wc -l > > 2 > > > > ./scripts/checkpatch.pl --no-tree --file > drivers/leds/simple/simatic-ipc-leds-gpio.h > > it boils down to header versus c-file, not sure why headers prefer that > other style Ah yes, that one. Okay.
On Thu, 06 Jul 2023, Henning Schild wrote: > This was found with giving the file to checkpatch. > > Signed-off-by: Henning Schild <henning.schild@siemens.com> > --- > drivers/leds/simple/simatic-ipc-leds-gpio.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks
diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.h b/drivers/leds/simple/simatic-ipc-leds-gpio.h index bf258c32f83d..3d4877aa4e0c 100644 --- a/drivers/leds/simple/simatic-ipc-leds-gpio.h +++ b/drivers/leds/simple/simatic-ipc-leds-gpio.h @@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0 +/* SPDX-License-Identifier: GPL-2.0 */ /* * Siemens SIMATIC IPC driver for GPIO based LEDs *
This was found with giving the file to checkpatch. Signed-off-by: Henning Schild <henning.schild@siemens.com> --- drivers/leds/simple/simatic-ipc-leds-gpio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)