diff mbox series

media: Switch three more drivers back to use struct i2c_driver::probe()

Message ID 20230718204541.3955386-1-u.kleine-koenig@pengutronix.de
State Accepted
Commit f2183847cf65c8df3ffcf0e7ee7d11425c93794e
Headers show
Series media: Switch three more drivers back to use struct i2c_driver::probe() | expand

Commit Message

Uwe Kleine-König July 18, 2023, 8:45 p.m. UTC 
struct i2c_driver::probe_new() is about to go away. Since I converted
all drivers below drivers/media use struct i2c_driver::probe, three more
drivers were added in the following commits that use .probe_new():

	6363db1c9d45 media: i2c: add DS90UB953 driver
	c158d0d4ff15 media: i2c: add DS90UB913 driver
	afe267f2d368 media: i2c: add DS90UB960 driver

Switch these driver to use the probe callback.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,

these three drivers are currently added in next and introduce new usages
of .probe_new which I intend to remove after the next -rc1.

To reduce the amount of patches that are necessary to apply together
with the patch that drops .probe_new() it would be great if you make
sure that this patch makes it in before v6.6-rc1.

Thanks
Uwe

 drivers/media/i2c/ds90ub913.c | 2 +-
 drivers/media/i2c/ds90ub953.c | 2 +-
 drivers/media/i2c/ds90ub960.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)


base-commit: 6363db1c9d45a54ddc1582423b74b5f9935b5958

Comments

Kieran Bingham July 20, 2023, 7:41 a.m. UTC | #1 
Hi Uwe,

Quoting Uwe Kleine-König (2023-07-18 21:45:41)
> struct i2c_driver::probe_new() is about to go away. Since I converted
> all drivers below drivers/media use struct i2c_driver::probe, three more
> drivers were added in the following commits that use .probe_new():
> 
>         6363db1c9d45 media: i2c: add DS90UB953 driver
>         c158d0d4ff15 media: i2c: add DS90UB913 driver
>         afe267f2d368 media: i2c: add DS90UB960 driver


Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> 
> Switch these driver to use the probe callback.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
> 
> these three drivers are currently added in next and introduce new usages
> of .probe_new which I intend to remove after the next -rc1.
> 
> To reduce the amount of patches that are necessary to apply together
> with the patch that drops .probe_new() it would be great if you make
> sure that this patch makes it in before v6.6-rc1.
> 
> Thanks
> Uwe
> 
>  drivers/media/i2c/ds90ub913.c | 2 +-
>  drivers/media/i2c/ds90ub953.c | 2 +-
>  drivers/media/i2c/ds90ub960.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/i2c/ds90ub913.c b/drivers/media/i2c/ds90ub913.c
> index 203f7cceae23..4dae5afa9fa9 100644
> --- a/drivers/media/i2c/ds90ub913.c
> +++ b/drivers/media/i2c/ds90ub913.c
> @@ -889,7 +889,7 @@ static const struct of_device_id ub913_dt_ids[] = {
>  MODULE_DEVICE_TABLE(of, ub913_dt_ids);
>  
>  static struct i2c_driver ds90ub913_driver = {
> -       .probe_new      = ub913_probe,
> +       .probe          = ub913_probe,
>         .remove         = ub913_remove,
>         .id_table       = ub913_id,
>         .driver = {
> diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c
> index 1e3827a60029..87a7420366ea 100644
> --- a/drivers/media/i2c/ds90ub953.c
> +++ b/drivers/media/i2c/ds90ub953.c
> @@ -1382,7 +1382,7 @@ static const struct of_device_id ub953_dt_ids[] = {
>  MODULE_DEVICE_TABLE(of, ub953_dt_ids);
>  
>  static struct i2c_driver ds90ub953_driver = {
> -       .probe_new      = ub953_probe,
> +       .probe          = ub953_probe,
>         .remove         = ub953_remove,
>         .id_table       = ub953_id,
>         .driver = {
> diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c
> index e101bcf2356a..548c257f922f 100644
> --- a/drivers/media/i2c/ds90ub960.c
> +++ b/drivers/media/i2c/ds90ub960.c
> @@ -4034,7 +4034,7 @@ static const struct of_device_id ub960_dt_ids[] = {
>  MODULE_DEVICE_TABLE(of, ub960_dt_ids);
>  
>  static struct i2c_driver ds90ub960_driver = {
> -       .probe_new      = ub960_probe,
> +       .probe          = ub960_probe,
>         .remove         = ub960_remove,
>         .id_table       = ub960_id,
>         .driver = {
> 
> base-commit: 6363db1c9d45a54ddc1582423b74b5f9935b5958
> -- 
> 2.39.2
>
Laurent Pinchart July 25, 2023, 9:40 p.m. UTC | #2 
Hello Uwe,

Thank you for the patch.

On Tue, Jul 18, 2023 at 10:45:41PM +0200, Uwe Kleine-König wrote:
> struct i2c_driver::probe_new() is about to go away. Since I converted
> all drivers below drivers/media use struct i2c_driver::probe, three more
> drivers were added in the following commits that use .probe_new():
> 
> 	6363db1c9d45 media: i2c: add DS90UB953 driver
> 	c158d0d4ff15 media: i2c: add DS90UB913 driver
> 	afe267f2d368 media: i2c: add DS90UB960 driver
> 
> Switch these driver to use the probe callback.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> Hello,
> 
> these three drivers are currently added in next and introduce new usages
> of .probe_new which I intend to remove after the next -rc1.
> 
> To reduce the amount of patches that are necessary to apply together
> with the patch that drops .probe_new() it would be great if you make
> sure that this patch makes it in before v6.6-rc1.
> 
> Thanks
> Uwe
> 
>  drivers/media/i2c/ds90ub913.c | 2 +-
>  drivers/media/i2c/ds90ub953.c | 2 +-
>  drivers/media/i2c/ds90ub960.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/i2c/ds90ub913.c b/drivers/media/i2c/ds90ub913.c
> index 203f7cceae23..4dae5afa9fa9 100644
> --- a/drivers/media/i2c/ds90ub913.c
> +++ b/drivers/media/i2c/ds90ub913.c
> @@ -889,7 +889,7 @@ static const struct of_device_id ub913_dt_ids[] = {
>  MODULE_DEVICE_TABLE(of, ub913_dt_ids);
>  
>  static struct i2c_driver ds90ub913_driver = {
> -	.probe_new	= ub913_probe,
> +	.probe		= ub913_probe,
>  	.remove		= ub913_remove,
>  	.id_table	= ub913_id,
>  	.driver = {
> diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c
> index 1e3827a60029..87a7420366ea 100644
> --- a/drivers/media/i2c/ds90ub953.c
> +++ b/drivers/media/i2c/ds90ub953.c
> @@ -1382,7 +1382,7 @@ static const struct of_device_id ub953_dt_ids[] = {
>  MODULE_DEVICE_TABLE(of, ub953_dt_ids);
>  
>  static struct i2c_driver ds90ub953_driver = {
> -	.probe_new	= ub953_probe,
> +	.probe		= ub953_probe,
>  	.remove		= ub953_remove,
>  	.id_table	= ub953_id,
>  	.driver = {
> diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c
> index e101bcf2356a..548c257f922f 100644
> --- a/drivers/media/i2c/ds90ub960.c
> +++ b/drivers/media/i2c/ds90ub960.c
> @@ -4034,7 +4034,7 @@ static const struct of_device_id ub960_dt_ids[] = {
>  MODULE_DEVICE_TABLE(of, ub960_dt_ids);
>  
>  static struct i2c_driver ds90ub960_driver = {
> -	.probe_new	= ub960_probe,
> +	.probe		= ub960_probe,
>  	.remove		= ub960_remove,
>  	.id_table	= ub960_id,
>  	.driver = {
> 
> base-commit: 6363db1c9d45a54ddc1582423b74b5f9935b5958
diff mbox series

Patch

diff --git a/drivers/media/i2c/ds90ub913.c b/drivers/media/i2c/ds90ub913.c
index 203f7cceae23..4dae5afa9fa9 100644
--- a/drivers/media/i2c/ds90ub913.c
+++ b/drivers/media/i2c/ds90ub913.c
@@ -889,7 +889,7 @@  static const struct of_device_id ub913_dt_ids[] = {
 MODULE_DEVICE_TABLE(of, ub913_dt_ids);
 
 static struct i2c_driver ds90ub913_driver = {
-	.probe_new	= ub913_probe,
+	.probe		= ub913_probe,
 	.remove		= ub913_remove,
 	.id_table	= ub913_id,
 	.driver = {
diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c
index 1e3827a60029..87a7420366ea 100644
--- a/drivers/media/i2c/ds90ub953.c
+++ b/drivers/media/i2c/ds90ub953.c
@@ -1382,7 +1382,7 @@  static const struct of_device_id ub953_dt_ids[] = {
 MODULE_DEVICE_TABLE(of, ub953_dt_ids);
 
 static struct i2c_driver ds90ub953_driver = {
-	.probe_new	= ub953_probe,
+	.probe		= ub953_probe,
 	.remove		= ub953_remove,
 	.id_table	= ub953_id,
 	.driver = {
diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c
index e101bcf2356a..548c257f922f 100644
--- a/drivers/media/i2c/ds90ub960.c
+++ b/drivers/media/i2c/ds90ub960.c
@@ -4034,7 +4034,7 @@  static const struct of_device_id ub960_dt_ids[] = {
 MODULE_DEVICE_TABLE(of, ub960_dt_ids);
 
 static struct i2c_driver ds90ub960_driver = {
-	.probe_new	= ub960_probe,
+	.probe		= ub960_probe,
 	.remove		= ub960_remove,
 	.id_table	= ub960_id,
 	.driver = {