diff mbox series

[1/2] dt-bindings: arm: aspeed: add Facebook Yosemite V4 board

Message ID 20230727033926.1904529-1-Delphine_CC_Chiu@wiwynn.com
State Superseded
Headers show
Series ARM: dts: Facebook Yosemite V4 platform | expand

Commit Message

Delphine CC Chiu July 27, 2023, 3:39 a.m. UTC
Document the new compatibles used on Facebook Yosemite V4.

Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Aug. 3, 2023, 11:14 a.m. UTC | #1
On 02/08/2023 04:34, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: Thursday, July 27, 2023 2:49 PM
>> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>;
>> patrick@stwcx.xyz; Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
>> <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>;
>> Joel Stanley <joel@jms.id.au>; Andrew Jeffery <andrew@aj.id.au>
>> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
>> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite V4
>> board
>>
>>   Security Reminder: Please be aware that this email is sent by an external
>> sender.
>>
>> On 27/07/2023 05:39, Delphine CC Chiu wrote:
>>> Document the new compatibles used on Facebook Yosemite V4.
>>>
>>> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
>>> ---
>>>  Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
>>>  1 file changed, 1 insertion(+)
>>
>> I got the same patch four times...
> It was my oversight to send the same patch multiple times.
> Would you please to tell that should I resend a new version, or these patches has been already under reviewed.
> Thank you.

I don't see versioning, no changelog. Thus if you send the same patches
all the time, then answer is - please version your patches, implement
the feedback and explain in changelog what changed.

Otherwise it will not get reviewed, so I assume this was not reviewed
and it is waiting for proper submission.

Best regards,
Krzysztof
Delphine CC Chiu Aug. 4, 2023, 10:06 a.m. UTC | #2
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Thursday, August 3, 2023 7:14 PM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>;
> patrick@stwcx.xyz; Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>;
> Joel Stanley <joel@jms.id.au>; Andrew Jeffery <andrew@aj.id.au>
> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite
> V4 board
> 
>   Security Reminder: Please be aware that this email is sent by an external
> sender.
> 
> On 02/08/2023 04:34, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> Sent: Thursday, July 27, 2023 2:49 PM
> >> To: Delphine_CC_Chiu/WYHQ/Wiwynn
> <Delphine_CC_Chiu@wiwynn.com>;
> >> patrick@stwcx.xyz; Rob Herring <robh+dt@kernel.org>; Krzysztof
> >> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
> >> <conor+dt@kernel.org>; Joel Stanley <joel@jms.id.au>; Andrew Jeffery
> >> <andrew@aj.id.au>
> >> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> >> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
> >> Subject: Re: [PATCH 1/2] dt-bindings: arm: aspeed: add Facebook
> >> Yosemite V4 board
> >>
> >>   Security Reminder: Please be aware that this email is sent by an
> >> external sender.
> >>
> >> On 27/07/2023 05:39, Delphine CC Chiu wrote:
> >>> Document the new compatibles used on Facebook Yosemite V4.
> >>>
> >>> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
> >>> ---
> >>>  Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>
> >> I got the same patch four times...
> > It was my oversight to send the same patch multiple times.
> > Would you please to tell that should I resend a new version, or these
> patches has been already under reviewed.
> > Thank you.
> 
> I don't see versioning, no changelog. Thus if you send the same patches all
> the time, then answer is - please version your patches, implement the
> feedback and explain in changelog what changed.
It seems that versioning didn't added successfully in duplicated patches.

I will update v5 patches for versioning, changelogs and all feedback's implementation, without duplicating sending.
Please help to tell if there's any feedback I lost, thank you.
> 
> Otherwise it will not get reviewed, so I assume this was not reviewed and it
> is waiting for proper submission.
> 
> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
index e0eff4c05879..2ef6821e3648 100644
--- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
+++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
@@ -79,6 +79,7 @@  properties:
               - facebook,elbert-bmc
               - facebook,fuji-bmc
               - facebook,greatlakes-bmc
+              - facebook,yosemitev4-bmc
               - ibm,everest-bmc
               - ibm,rainier-bmc
               - ibm,tacoma-bmc