| Message ID | 20230728134819.3224045-1-robh@kernel.org |
|---|---|
| State | Accepted |
| Commit | 86cdae14a58a877ee1ec79d39b1331bc98dace58 |
| Headers | show |
| Series | [v3] ipmi: Explicitly include correct DT includes | expand |
diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c index 2dea8cd5a09a..72640da55380 100644 --- a/drivers/char/ipmi/kcs_bmc_aspeed.c +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c @@ -14,7 +14,6 @@ #include <linux/module.h> #include <linux/of.h> #include <linux/of_address.h> -#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/poll.h> #include <linux/regmap.h>
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it was merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Signed-off-by: Rob Herring <robh@kernel.org> --- v3: - Split out hw_random, ipmi and tpm --- drivers/char/ipmi/kcs_bmc_aspeed.c | 1 - 1 file changed, 1 deletion(-)