[v2,23/47] fbdev/maxinefb: Use fbdev I/O helpers

Message ID	20230801101541.900-24-tzimmermann@suse.de
State	Accepted
Commit	e4f10ea72967051ee136cbdf36f822ed3d417271
Headers	show Return-Path: <linux-media-owner@vger.kernel.org> From: Thomas Zimmermann <tzimmermann@suse.de> To: deller@gmx.de, javierm@redhat.com, sam@ravnborg.org Cc: linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-geode@lists.infradead.org, linux-omap@vger.kernel.org, kvm@vger.kernel.org, Thomas Zimmermann <tzimmermann@suse.de> Subject: [PATCH v2 23/47] fbdev/maxinefb: Use fbdev I/O helpers Date: Tue, 1 Aug 2023 12:13:28 +0200 Message-ID: <20230801101541.900-24-tzimmermann@suse.de> In-Reply-To: <20230801101541.900-1-tzimmermann@suse.de> References: <20230801101541.900-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	fbdev: Use I/O helpers \| expand [v2,00/47] fbdev: Use I/O helpers [v2,01/47] media/vivid: Use fbdev I/O helpers [v2,02/47] fbdev/acornfb: Use fbdev I/O helpers [v2,03/47] fbdev/asiliantfb: Use fbdev I/O helpers [v2,04/47] fbdev/atmel_lcdfb: Use fbdev I/O helpers [v2,05/47] fbdev/aty128fb: Use fbdev I/O helpers [v2,06/47] fbdev/carminefb: Use fbdev I/O helpers [v2,07/47] fbdev/chipsfb: Use fbdev I/O helpers [v2,08/47] fbdev/da8xx-fb: Use fbdev I/O helpers [v2,09/47] fbdev/efifb: Use fbdev I/O helpers [v2,10/47] fbdev/fm2fb: Use fbdev I/O helpers [v2,11/47] fbdev/fsl-diu-fb: Use fbdev I/O helpers [v2,12/47] fbdev/g364fb: Use fbdev I/O helpers [v2,13/47] fbdev/geode/gx1fb: Use fbdev I/O helpers [v2,14/47] fbdev/geode/gxfb: Use fbdev I/O helpers [v2,15/47] fbdev/geode/lxfb: Use fbdev I/O helpers [v2,16/47] fbdev/goldfishfb: Use fbdev I/O helpers [v2,17/47] fbdev/grvga: Use fbdev I/O helpers [v2,18/47] fbdev/gxt4500: Use fbdev I/O helpers [v2,19/47] fbdev/i740fb: Use fbdev I/O helpers [v2,20/47] fbdev/imxfb: Use fbdev I/O helpers [v2,21/47] fbdev/kyro: Use fbdev I/O helpers [v2,22/47] fbdev/macfb: Use fbdev I/O helpers [v2,23/47] fbdev/maxinefb: Use fbdev I/O helpers [v2,24/47] fbdev/mb862xxfb: Use fbdev I/O helpers [v2,25/47] fbdev/mmpfb: Use fbdev I/O helpers [v2,26/47] fbdev/mx3fb: Use fbdev I/O helpers [v2,27/47] fbdev/ocfb: Use fbdev I/O helpers [v2,28/47] fbdev/offb: Use fbdev I/O helpers [v2,29/47] fbdev/omapfb: Use fbdev I/O helpers [v2,30/47] fbdev/platinumfb: Use fbdev I/O helpers [v2,31/47] fbdev/pmag-aa-fb: Use fbdev I/O helpers [v2,32/47] fbdev/pmag-ba-fb: Use fbdev I/O helpers [v2,33/47] fbdev/pmagb-b-fb: Use fbdev I/O helpers [v2,34/47] fbdev/pxa168fb: Use fbdev I/O helpers [v2,35/47] fbdev/pxafb: Use fbdev I/O helpers [v2,36/47] fbdev/q40fb: Use fbdev I/O helpers [v2,37/47] fbdev/s3cfb: Use fbdev I/O helpers [v2,38/47] fbdev/sh7760fb: Use fbdev I/O helpers [v2,39/47] fbdev/simplefb: Use fbdev I/O helpers [v2,40/47] fbdev/sstfb: Use fbdev I/O helpers [v2,41/47] fbdev/sunxvr1000: Use fbdev I/O helpers [v2,42/47] fbdev/sunxvr2500: Use fbdev I/O helpers [v2,43/47] fbdev/uvesafb: Use fbdev I/O helpers [v2,44/47] fbdev/valkyriefb: Use fbdev I/O helpers [v2,45/47] fbdev/vesafb: Use fbdev I/O helpers [v2,46/47] fbdev/xilinxfb: Use fbdev I/O helpers [v2,47/47] vfio-dev/mdpy-fb: Use fbdev I/O helpers

Message ID

20230801101541.900-24-tzimmermann@suse.de

State

Accepted

Commit

e4f10ea72967051ee136cbdf36f822ed3d417271

Headers

From: Thomas Zimmermann <tzimmermann@suse.de>
To: deller@gmx.de, javierm@redhat.com, sam@ravnborg.org
Cc: linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org,
        linux-geode@lists.infradead.org, linux-omap@vger.kernel.org,
        kvm@vger.kernel.org, Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 23/47] fbdev/maxinefb: Use fbdev I/O helpers
Date: Tue,  1 Aug 2023 12:13:28 +0200
Message-ID: <20230801101541.900-24-tzimmermann@suse.de>
In-Reply-To: <20230801101541.900-1-tzimmermann@suse.de>
References: <20230801101541.900-1-tzimmermann@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

fbdev: Use I/O helpers | expand

Commit Message

Thomas Zimmermann Aug. 1, 2023, 10:13 a.m. UTC

Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IO_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v2:
	* updated to use _IOMEM_ tokens

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Helge Deller <deller@gmx.de>
---
 drivers/video/fbdev/Kconfig    | 4 +---
 drivers/video/fbdev/maxinefb.c | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index c7ee242985ed..f958290c83e5 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -1556,9 +1556,7 @@  config FB_PMAGB_B
 config FB_MAXINE
 	bool "Maxine (Personal DECstation) onboard framebuffer support"
 	depends on (FB = y) && MACH_DECSTATION
-	select FB_CFB_FILLRECT
-	select FB_CFB_COPYAREA
-	select FB_CFB_IMAGEBLIT
+	select FB_IOMEM_HELPERS
 	help
 	  Support for the onboard framebuffer (1024x768x8) in the Personal
 	  DECstation series (Personal DECstation 5000/20, /25, /33, /50,
diff --git a/drivers/video/fbdev/maxinefb.c b/drivers/video/fbdev/maxinefb.c
index 0ac1873b2acb..52528eb4dfb4 100644
--- a/drivers/video/fbdev/maxinefb.c
+++ b/drivers/video/fbdev/maxinefb.c
@@ -107,10 +107,8 @@  static int maxinefb_setcolreg(unsigned regno, unsigned red, unsigned green,
 
 static const struct fb_ops maxinefb_ops = {
 	.owner		= THIS_MODULE,
+	FB_DEFAULT_IOMEM_OPS,
 	.fb_setcolreg	= maxinefb_setcolreg,
-	.fb_fillrect	= cfb_fillrect,
-	.fb_copyarea	= cfb_copyarea,
-	.fb_imageblit	= cfb_imageblit,
 };
 
 int __init maxinefb_init(void)

[v2,23/47] fbdev/maxinefb: Use fbdev I/O helpers

Commit Message

Patch