| Message ID | 20230823110758.3462-1-aboutphysycs@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | char: hw_random: ba431-rng: removed unneeded call to platform_set_drvdata() | expand |
Andrei Coardos (aboutphysycs@gmail.com) wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. > Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> > --- > drivers/char/hw_random/ba431-rng.c | 2 -- > 1 file changed, 2 deletions(-) > diff --git a/drivers/char/hw_random/ba431-rng.c b/drivers/char/hw_random/ba431-rng.c > index 5b7ca0416490..b1518dd52a24 100644 > --- a/drivers/char/hw_random/ba431-rng.c > +++ b/drivers/char/hw_random/ba431-rng.c > @@ -189,8 +189,6 @@ static int ba431_trng_probe(struct platform_device *pdev) > ba431->rng.cleanup = ba431_trng_cleanup; > ba431->rng.read = ba431_trng_read; > - platform_set_drvdata(pdev, ba431); > - > ret = devm_hwrng_register(&pdev->dev, &ba431->rng); > if (ret) { > dev_err(&pdev->dev, "BA431 registration failed (%d)\n", ret); > -- > 2.34.1 This was already removed in e8c1fdcc62d3 ("hwrng: ba431 - do not set drvdata").
diff --git a/drivers/char/hw_random/ba431-rng.c b/drivers/char/hw_random/ba431-rng.c index 5b7ca0416490..b1518dd52a24 100644 --- a/drivers/char/hw_random/ba431-rng.c +++ b/drivers/char/hw_random/ba431-rng.c @@ -189,8 +189,6 @@ static int ba431_trng_probe(struct platform_device *pdev) ba431->rng.cleanup = ba431_trng_cleanup; ba431->rng.read = ba431_trng_read; - platform_set_drvdata(pdev, ba431); - ret = devm_hwrng_register(&pdev->dev, &ba431->rng); if (ret) { dev_err(&pdev->dev, "BA431 registration failed (%d)\n", ret);
This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file. Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> --- drivers/char/hw_random/ba431-rng.c | 2 -- 1 file changed, 2 deletions(-)