diff mbox series

[v3,4/6] dt-bindings: crypto: qcom,prng: document SM8550

Message ID 20230828-topic-sm8550-rng-v3-4-7a0678ca7988@linaro.org
State New
Headers show
Series arm64: qcom: sm8550: enable RNG | expand

Commit Message

Neil Armstrong Aug. 28, 2023, 8:04 a.m. UTC 
Document SM8550 compatible for the True Random Number Generator.

Reviewed-by: Om Prakash Singh <quic_omprsing@quicinc.com>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Rob Herring (Arm) Aug. 28, 2023, 9:36 p.m. UTC | #1 
On Mon, Aug 28, 2023 at 10:04:39AM +0200, Neil Armstrong wrote:
> Document SM8550 compatible for the True Random Number Generator.
> 
> Reviewed-by: Om Prakash Singh <quic_omprsing@quicinc.com>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>

Where's Krzysztof's tag?

> ---
>  Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> index 4245c9e424a3..633993f801c6 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> @@ -16,7 +16,9 @@ properties:
>            - qcom,prng  # 8916 etc.
>            - qcom,prng-ee  # 8996 and later using EE
>        - items:
> -          - const: qcom,sm8450-trng
> +          - enum:
> +              - qcom,sm8450-trng
> +              - qcom,sm8550-trng
>            - const: qcom,trng
>  
>    reg:
> 
> -- 
> 2.34.1
>
Krzysztof Kozlowski Aug. 29, 2023, 6:38 a.m. UTC | #2 
On 28/08/2023 23:36, Rob Herring wrote:
> On Mon, Aug 28, 2023 at 10:04:39AM +0200, Neil Armstrong wrote:
>> Document SM8550 compatible for the True Random Number Generator.
>>
>> Reviewed-by: Om Prakash Singh <quic_omprsing@quicinc.com>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> 
> Where's Krzysztof's tag?
> 

The patch evolved and Neil mentioned in cover letter changelog that he
did not collect Reviews because of that. Seems ok for me.

For the patch:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Rob Herring (Arm) Aug. 29, 2023, 4:22 p.m. UTC | #3 
On Tue, Aug 29, 2023 at 08:38:48AM +0200, Krzysztof Kozlowski wrote:
> On 28/08/2023 23:36, Rob Herring wrote:
> > On Mon, Aug 28, 2023 at 10:04:39AM +0200, Neil Armstrong wrote:
> >> Document SM8550 compatible for the True Random Number Generator.
> >>
> >> Reviewed-by: Om Prakash Singh <quic_omprsing@quicinc.com>
> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> > 
> > Where's Krzysztof's tag?
> > 
> 
> The patch evolved and Neil mentioned in cover letter changelog that he
> did not collect Reviews because of that. Seems ok for me.

I did go look there and just saw 'Added review tags'. Not too helpful.  
That's why changelogs for a patch belong in the patch.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
index 4245c9e424a3..633993f801c6 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
@@ -16,7 +16,9 @@  properties:
           - qcom,prng  # 8916 etc.
           - qcom,prng-ee  # 8996 and later using EE
       - items:
-          - const: qcom,sm8450-trng
+          - enum:
+              - qcom,sm8450-trng
+              - qcom,sm8550-trng
           - const: qcom,trng
 
   reg: