| Message ID | 20230828224201.26823-1-rdunlap@infradead.org |
|---|---|
| State | Accepted |
| Commit | 37d1a624cb7934687dd9775f7fea771ae5aadd29 |
| Headers | show |
| Series | power: supply: rt5033_charger: recognize EXTCON setting | expand |
On Mon, 28 Aug 2023 15:42:01 -0700, Randy Dunlap wrote: > CHARGER_RT5033 should honor the EXTCON setting to prevent these > build errors: > > riscv64-linux-ld: drivers/power/supply/rt5033_charger.o: in function `.L33': > rt5033_charger.c:(.text.rt5033_charger_probe+0x578): undefined reference to `extcon_find_edev_by_node' > riscv64-linux-ld: drivers/power/supply/rt5033_charger.o: in function `.L0 ': > rt5033_charger.c:(.text.rt5033_charger_probe+0x64e): undefined reference to `devm_extcon_register_notifier_all' > riscv64-linux-ld: drivers/power/supply/rt5033_charger.o: in function `.L96': > rt5033_charger.c:(.text.rt5033_charger_extcon_work+0x32): undefined reference to `extcon_get_state' > > [...] Applied, thanks! [1/1] power: supply: rt5033_charger: recognize EXTCON setting commit: 37d1a624cb7934687dd9775f7fea771ae5aadd29 Best regards,
diff -- a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig --- a/drivers/power/supply/Kconfig +++ b/drivers/power/supply/Kconfig @@ -769,6 +769,7 @@ config BATTERY_RT5033 config CHARGER_RT5033 tristate "RT5033 battery charger support" depends on MFD_RT5033 + depends on EXTCON || !EXTCON help This adds support for battery charger in Richtek RT5033 PMIC. The device supports pre-charge mode, fast charge mode and
CHARGER_RT5033 should honor the EXTCON setting to prevent these build errors: riscv64-linux-ld: drivers/power/supply/rt5033_charger.o: in function `.L33': rt5033_charger.c:(.text.rt5033_charger_probe+0x578): undefined reference to `extcon_find_edev_by_node' riscv64-linux-ld: drivers/power/supply/rt5033_charger.o: in function `.L0 ': rt5033_charger.c:(.text.rt5033_charger_probe+0x64e): undefined reference to `devm_extcon_register_notifier_all' riscv64-linux-ld: drivers/power/supply/rt5033_charger.o: in function `.L96': rt5033_charger.c:(.text.rt5033_charger_extcon_work+0x32): undefined reference to `extcon_get_state' Fixes: 12cc585f36b8 ("power: supply: rt5033_charger: Add cable detection and USB OTG supply") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Jakob Hauser <jahau@rocketmail.com> Cc: Sebastian Reichel <sre@kernel.org> Cc: Lee Jones <lee@kernel.org> Cc: linux-pm@vger.kernel.org --- drivers/power/supply/Kconfig | 1 + 1 file changed, 1 insertion(+)