| Message ID | 20230908101223.2656901-1-rf@opensource.cirrus.com |
|---|---|
| State | Accepted |
| Commit | caaaa34eff2a3fc4e61bfccde9e15ae5dba49a7d |
| Headers | show |
| Series | ALSA: hda: cs35l56: Call pm_runtime_dont_use_autosuspend() | expand |
On Fri, 08 Sep 2023 12:12:23 +0200, Richard Fitzgerald wrote: > > Driver remove() must call pm_runtime_dont_use_autosuspend(). > > Drivers that call pm_runtime_use_autosuspend() must disable > it in driver remove(). Unfortunately until recently this was > only mentioned in 1 line in a 900+ line document so most > people hadn't noticed this. It has only recently been added > to the kerneldoc of pm_runtime_use_autosuspend(). > > Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> > Fixes: 2a930a6da8ec ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier") Applied now. The Fixes tag points to a non-existing ID, so I corrected in my side to 73cfbfa9caea. thanks, Takashi > --- > sound/pci/hda/cs35l56_hda.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c > index 76b9c685560b..9e4976bdb5e0 100644 > --- a/sound/pci/hda/cs35l56_hda.c > +++ b/sound/pci/hda/cs35l56_hda.c > @@ -1003,6 +1003,7 @@ void cs35l56_hda_remove(struct device *dev) > { > struct cs35l56_hda *cs35l56 = dev_get_drvdata(dev); > > + pm_runtime_dont_use_autosuspend(cs35l56->base.dev); > pm_runtime_get_sync(cs35l56->base.dev); > pm_runtime_disable(cs35l56->base.dev); > > -- > 2.30.2 >
diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c index 76b9c685560b..9e4976bdb5e0 100644 --- a/sound/pci/hda/cs35l56_hda.c +++ b/sound/pci/hda/cs35l56_hda.c @@ -1003,6 +1003,7 @@ void cs35l56_hda_remove(struct device *dev) { struct cs35l56_hda *cs35l56 = dev_get_drvdata(dev); + pm_runtime_dont_use_autosuspend(cs35l56->base.dev); pm_runtime_get_sync(cs35l56->base.dev); pm_runtime_disable(cs35l56->base.dev);
Driver remove() must call pm_runtime_dont_use_autosuspend(). Drivers that call pm_runtime_use_autosuspend() must disable it in driver remove(). Unfortunately until recently this was only mentioned in 1 line in a 900+ line document so most people hadn't noticed this. It has only recently been added to the kerneldoc of pm_runtime_use_autosuspend(). Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> Fixes: 2a930a6da8ec ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier") --- sound/pci/hda/cs35l56_hda.c | 1 + 1 file changed, 1 insertion(+)