| Message ID | 20230911-msm8916-rmem-v1-9-b7089ec3e3a1@gerhold.net |
|---|---|
| State | Accepted |
| Commit | e3c6386c6a5d0187f103fc9bf39850ac15c01690 |
| Headers | show |
| Series | arm64: dts: qcom: msm8916/39: Reserve firmware memory dynamically | expand |
On 11.09.2023 19:41, Stephan Gerhold wrote: > Both MSM8916 and MSM8939 have unnecessarily large reservations for the > venus firmware for some reason. According to the ELF headers and > downstream [1] 5 MiB is enough. Let's set the minimum size as default. > > With the dynamic reserved memory allocations boards can easily override > this if needed, although in practice there does not seem to be any > device with a different venus firmware size. > > [1]: https://git.codelinaro.org/clo/la/kernel/msm-3.10/-/blame/LA.BR.1.2.9.1-02310-8x16.0/arch/arm/boot/dts/qcom/msm8939-common.dtsi#L69 > > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> > --- Every meg counts when you only have a gig and change! I'd prefer this to be separate patches for 16 and 39 though.. Konrad
diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi index 4d867078388d..1e94e26b8fb0 100644 --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi @@ -98,7 +98,7 @@ wcnss_mem: wcnss { }; venus_mem: venus { - size = <0x0 0x600000>; + size = <0x0 0x500000>; alignment = <0x0 0x100000>; alloc-ranges = <0x0 0x86800000 0x0 0x8000000>; no-map; diff --git a/arch/arm64/boot/dts/qcom/msm8939.dtsi b/arch/arm64/boot/dts/qcom/msm8939.dtsi index ba177725f3d7..715c86c217c5 100644 --- a/arch/arm64/boot/dts/qcom/msm8939.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8939.dtsi @@ -370,7 +370,7 @@ wcnss_mem: wcnss { }; venus_mem: venus { - size = <0x0 0x800000>; + size = <0x0 0x500000>; alignment = <0x0 0x100000>; alloc-ranges = <0x0 0x86800000 0x0 0x8000000>; no-map;
Both MSM8916 and MSM8939 have unnecessarily large reservations for the venus firmware for some reason. According to the ELF headers and downstream [1] 5 MiB is enough. Let's set the minimum size as default. With the dynamic reserved memory allocations boards can easily override this if needed, although in practice there does not seem to be any device with a different venus firmware size. [1]: https://git.codelinaro.org/clo/la/kernel/msm-3.10/-/blame/LA.BR.1.2.9.1-02310-8x16.0/arch/arm/boot/dts/qcom/msm8939-common.dtsi#L69 Signed-off-by: Stephan Gerhold <stephan@gerhold.net> --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +- arch/arm64/boot/dts/qcom/msm8939.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)