| Message ID | 20230912045157.177966-36-claudiu.beznea.uj@bp.renesas.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add new Renesas RZ/G3S SoC and RZ/G3S SMARC EVK | expand |
On Tue, Sep 12, 2023 at 07:51:55AM +0300, Claudiu wrote: > From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > Document Renesas SMARC Carrier-II EVK board which is based on RZ/G3S > (R9A08G045) SoC. The SMARC Carrier-II EVK consists of RZ/G3S SoM module and > SMARC Carrier-II carrier board, the SoM module sits on top of carrier > board. > > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > --- > Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml > index 822faf081e84..f4964445e5ab 100644 > --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml > @@ -476,6 +476,8 @@ properties: > > - description: RZ/G3S (R9A08G045) > items: > + - enum: > + - renesas,smarc2-evk # SMARC Carrier-II EVK You just changed the existing binding... > - enum: > - renesas,r9a08g045s33 # PCIe support This is the SoM module? You either need to squash this change or add another case with 3 entries and maintain the 2 entry case. (there's no way to express any entry at the beginning or middle can be optional) > - const: renesas,r9a08g045 > -- > 2.39.2 >
On 12.09.2023 19:16, Rob Herring wrote: > On Tue, Sep 12, 2023 at 07:51:55AM +0300, Claudiu wrote: >> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> >> >> Document Renesas SMARC Carrier-II EVK board which is based on RZ/G3S >> (R9A08G045) SoC. The SMARC Carrier-II EVK consists of RZ/G3S SoM module and >> SMARC Carrier-II carrier board, the SoM module sits on top of carrier >> board. >> >> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> >> --- >> Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml >> index 822faf081e84..f4964445e5ab 100644 >> --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml >> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml >> @@ -476,6 +476,8 @@ properties: >> >> - description: RZ/G3S (R9A08G045) >> items: >> + - enum: >> + - renesas,smarc2-evk # SMARC Carrier-II EVK > > You just changed the existing binding... > >> - enum: >> - renesas,r9a08g045s33 # PCIe support > > This is the SoM module? No, this is a SoC variant which supports PCIe. > You either need to squash this change or add > another case with 3 entries and maintain the 2 entry case. (there's no > way to express any entry at the beginning or middle can be optional) > >> - const: renesas,r9a08g045 >> -- >> 2.39.2 >>
Hi Claudiu, On Wed, Sep 13, 2023 at 7:32 AM claudiu beznea <claudiu.beznea@tuxon.dev> wrote: > On 12.09.2023 19:16, Rob Herring wrote: > > On Tue, Sep 12, 2023 at 07:51:55AM +0300, Claudiu wrote: > >> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > >> > >> Document Renesas SMARC Carrier-II EVK board which is based on RZ/G3S > >> (R9A08G045) SoC. The SMARC Carrier-II EVK consists of RZ/G3S SoM module and > >> SMARC Carrier-II carrier board, the SoM module sits on top of carrier > >> board. > >> > >> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> Thanks for your patch! > >> --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml > >> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml > >> @@ -476,6 +476,8 @@ properties: > >> > >> - description: RZ/G3S (R9A08G045) > >> items: > >> + - enum: > >> + - renesas,smarc2-evk # SMARC Carrier-II EVK > > > > You just changed the existing binding... > > > >> - enum: > >> - renesas,r9a08g045s33 # PCIe support > > > > This is the SoM module? > > No, this is a SoC variant which supports PCIe. Ideally, we need a compatible value for the SoM as well, as the SoM can be used stand-alone, or plugged in a different carrier board. For iWave Systems RZ/G1E SODIMM, we have that. For the existing RZ/G2L variants, we forgot, but it can still be added... > > > You either need to squash this change or add > > another case with 3 entries and maintain the 2 entry case. (there's no > > way to express any entry at the beginning or middle can be optional) > > > >> - const: renesas,r9a08g045 Gr{oetje,eeting}s, Geert
diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml index 822faf081e84..f4964445e5ab 100644 --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml @@ -476,6 +476,8 @@ properties: - description: RZ/G3S (R9A08G045) items: + - enum: + - renesas,smarc2-evk # SMARC Carrier-II EVK - enum: - renesas,r9a08g045s33 # PCIe support - const: renesas,r9a08g045