| Message ID | 20230914125115.30904-1-peter.ujfalusi@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | f7d67a9c254829930355d675e989c0dfa884242c |
| Headers | show |
| Series | ASoC: SOF: ipc4: Dump the payload also when set_get_data fails | expand |
On Thu, 14 Sep 2023 15:51:15 +0300, Peter Ujfalusi wrote: > Move the out label to dump the message payload when the IPC message fails. > The payload contains important information on what might have caused the > error in firmware. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: SOF: ipc4: Dump the payload also when set_get_data fails commit: f7d67a9c254829930355d675e989c0dfa884242c All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/sof/ipc4.c b/sound/soc/sof/ipc4.c index ab6eddd91bb7..9744627d6978 100644 --- a/sound/soc/sof/ipc4.c +++ b/sound/soc/sof/ipc4.c @@ -513,10 +513,10 @@ static int sof_ipc4_set_get_data(struct snd_sof_dev *sdev, void *data, if (!set && payload_bytes != offset) ipc4_msg->data_size = offset; +out: if (sof_debug_check_flag(SOF_DBG_DUMP_IPC_MESSAGE_PAYLOAD)) sof_ipc4_dump_payload(sdev, ipc4_msg->data_ptr, ipc4_msg->data_size); -out: mutex_unlock(&sdev->ipc->tx_mutex); return ret;