| Message ID | 20230926044814.535-1-quic_rkakarla@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] arm64: dts: qcom: sa8775p: Add RPMh sleep stats | expand |
On Tue, Sep 26, 2023 at 10:18:14AM +0530, Raghavendra Kakarla wrote: > Add device node for sleep stats driver which provides various > low power mode stats. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Raghavendra Kakarla <quic_rkakarla@quicinc.com> Tested-by: Andrew Halaney <ahalaney@redhat.com> I took this for a quick spin when testing -next today, and I see the qcom_stats directory, can view the file output, etc. Probably good enough to consider this simple change tested. I also don't see any new issues when running: ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make CHECK_DTBS=1 qcom/sa8775p-ride.dtb > --- Generally you should put a description of what changed since v1 in this section. > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > index 9f4f58e831a4..cee7491de675 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > @@ -1912,6 +1912,11 @@ > #clock-cells = <0>; > }; > > + sram@c3f0000 { > + compatible = "qcom,rpmh-stats"; > + reg = <0 0x0c3f0000 0 0x400>; > + }; > + > spmi_bus: spmi@c440000 { > compatible = "qcom,spmi-pmic-arb"; > reg = <0x0 0x0c440000 0x0 0x1100>, > -- > 2.17.1 >
On 9/27/2023 12:36 AM, Konrad Dybcio wrote: > On 26.09.2023 06:48, Raghavendra Kakarla wrote: >> Add device node for sleep stats driver which provides various >> low power mode stats. >> >> Cc: devicetree@vger.kernel.org >> Signed-off-by: Raghavendra Kakarla <quic_rkakarla@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi >> index 9f4f58e831a4..cee7491de675 100644 >> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi >> @@ -1912,6 +1912,11 @@ >> #clock-cells = <0>; >> }; >> >> + sram@c3f0000 { >> + compatible = "qcom,rpmh-stats"; >> + reg = <0 0x0c3f0000 0 0x400>; > Other nodes (such as the one 5 lines below) use 0x0 instead of > 0 to fill out bits 63:32. Please make it consistent. Sure, will address this in next patch. > > Konrad >> + }; >> + >> spmi_bus: spmi@c440000 { >> compatible = "qcom,spmi-pmic-arb"; >> reg = <0x0 0x0c440000 0x0 0x1100>,
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index 9f4f58e831a4..cee7491de675 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi @@ -1912,6 +1912,11 @@ #clock-cells = <0>; }; + sram@c3f0000 { + compatible = "qcom,rpmh-stats"; + reg = <0 0x0c3f0000 0 0x400>; + }; + spmi_bus: spmi@c440000 { compatible = "qcom,spmi-pmic-arb"; reg = <0x0 0x0c440000 0x0 0x1100>,
Add device node for sleep stats driver which provides various low power mode stats. Cc: devicetree@vger.kernel.org Signed-off-by: Raghavendra Kakarla <quic_rkakarla@quicinc.com> --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++ 1 file changed, 5 insertions(+)