| Message ID | 20230929154524.222498-1-dmantipov@yandex.ru |
|---|---|
| State | New |
| Headers | show |
| Series | wifi: rtlwifi: use unsigned long for rtl_bssid_entry timestamp | expand |
> -----Original Message----- > From: Dmitry Antipov <dmantipov@yandex.ru> > Sent: Friday, September 29, 2023 11:45 PM > To: Ping-Ke Shih <pkshih@realtek.com> > Cc: Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org; Dmitry Antipov <dmantipov@yandex.ru> > Subject: [PATCH] wifi: rtlwifi: use unsigned long for rtl_bssid_entry timestamp > > Since 'age' of 'struct rtl_bssid_entry' is in jiffies, prefer 'unsigned > long' over 'u32' to avoid possible truncation in 'rtl_collect_scan_list()' > and thus weird result in 'rtl_scan_list_expire()'. Compile tested only. > > Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> Acked-by: Ping-Ke Shih <pkshih@realtek.com> > --- > drivers/net/wireless/realtek/rtlwifi/wifi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/wifi.h b/drivers/net/wireless/realtek/rtlwifi/wifi.h > index 2e7e04f91279..0f99e3446796 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/wifi.h > +++ b/drivers/net/wireless/realtek/rtlwifi/wifi.h > @@ -2708,7 +2708,7 @@ struct rtl_c2hcmd { > struct rtl_bssid_entry { > struct list_head list; > u8 bssid[ETH_ALEN]; > - u32 age; > + unsigned long age; > }; > > struct rtl_scan_list { > -- > 2.41.0
Dmitry Antipov <dmantipov@yandex.ru> wrote: > Since 'age' of 'struct rtl_bssid_entry' is in jiffies, prefer 'unsigned > long' over 'u32' to avoid possible truncation in 'rtl_collect_scan_list()' > and thus weird result in 'rtl_scan_list_expire()'. Compile tested only. > > Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> > Acked-by: Ping-Ke Shih <pkshih@realtek.com> Patch applied to wireless-next.git, thanks. f0fb62e090bd wifi: rtlwifi: use unsigned long for rtl_bssid_entry timestamp
diff --git a/drivers/net/wireless/realtek/rtlwifi/wifi.h b/drivers/net/wireless/realtek/rtlwifi/wifi.h index 2e7e04f91279..0f99e3446796 100644 --- a/drivers/net/wireless/realtek/rtlwifi/wifi.h +++ b/drivers/net/wireless/realtek/rtlwifi/wifi.h @@ -2708,7 +2708,7 @@ struct rtl_c2hcmd { struct rtl_bssid_entry { struct list_head list; u8 bssid[ETH_ALEN]; - u32 age; + unsigned long age; }; struct rtl_scan_list {
Since 'age' of 'struct rtl_bssid_entry' is in jiffies, prefer 'unsigned long' over 'u32' to avoid possible truncation in 'rtl_collect_scan_list()' and thus weird result in 'rtl_scan_list_expire()'. Compile tested only. Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> --- drivers/net/wireless/realtek/rtlwifi/wifi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)