| Message ID | 20231010-pxa1908-lkml-v6-2-b2fe09240cf8@skole.hr |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Initial Marvell PXA1908 support | expand |
On 10/10/2023 19:27, Duje Mihanović wrote: > Add the "marvell,pxa1908-padconf" compatible to allow migrating to a > separate pinctrl driver later. > > Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr> > --- > Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml > index 45a307d3ce16..0f7e16a28990 100644 > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml > @@ -32,6 +32,10 @@ properties: > - ti,omap4-padconf > - ti,omap5-padconf > - const: pinctrl-single > + - items: > + - enum: > + - marvell,pxa1908-padconf There is enum above, so use it. Put your entry there, in alphabetical order. Best regards, Krzysztof
On Tue, Oct 10, 2023 at 07:27:19PM +0200, Duje Mihanović wrote: > Add the "marvell,pxa1908-padconf" compatible to allow migrating to a > separate pinctrl driver later. > > Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr> > --- > Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml > index 45a307d3ce16..0f7e16a28990 100644 > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml > @@ -32,6 +32,10 @@ properties: > - ti,omap4-padconf > - ti,omap5-padconf > - const: pinctrl-single > + - items: > + - enum: > + - marvell,pxa1908-padconf Just add this to the existing enum above. Rob
On Thu, Oct 12, 2023 at 2:53 PM Rob Herring <robh@kernel.org> wrote: > > On Tue, Oct 10, 2023 at 07:27:19PM +0200, Duje Mihanović wrote: > > Add the "marvell,pxa1908-padconf" compatible to allow migrating to a > > separate pinctrl driver later. > > > > Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr> > > --- > > Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml > > index 45a307d3ce16..0f7e16a28990 100644 > > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml > > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml > > @@ -32,6 +32,10 @@ properties: > > - ti,omap4-padconf > > - ti,omap5-padconf > > - const: pinctrl-single > > + - items: > > + - enum: > > + - marvell,pxa1908-padconf > > Just add this to the existing enum above. NM, I see it's pinconf-single, not pinctrl-single. Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml index 45a307d3ce16..0f7e16a28990 100644 --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml @@ -32,6 +32,10 @@ properties: - ti,omap4-padconf - ti,omap5-padconf - const: pinctrl-single + - items: + - enum: + - marvell,pxa1908-padconf + - const: pinconf-single reg: maxItems: 1
Add the "marvell,pxa1908-padconf" compatible to allow migrating to a separate pinctrl driver later. Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr> --- Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml | 4 ++++ 1 file changed, 4 insertions(+)