| Message ID | 20231025-topic-sm8650-upstream-remoteproc-v1-1-a8d20e4ce18c@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] dt-bindings: remoteproc: qcom,sm8550-pas: document the SM8650 PAS | expand |
On 25/10/2023 09:35, Neil Armstrong wrote: > Document the DSP Peripheral Authentication Service on the SM8650 Platform. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > .../bindings/remoteproc/qcom,sm8550-pas.yaml | 41 +++++++++++++++++++++- > 1 file changed, 40 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml > index 58120829fb06..316371c8ee6e 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml > @@ -19,6 +19,9 @@ properties: > - qcom,sm8550-adsp-pas > - qcom,sm8550-cdsp-pas > - qcom,sm8550-mpss-pas > + - qcom,sm8650-adsp-pas > + - qcom,sm8650-cdsp-pas > + - qcom,sm8650-mpss-pas > > reg: > maxItems: 1 > @@ -49,6 +52,7 @@ properties: > - description: Memory region for main Firmware authentication > - description: Memory region for Devicetree Firmware authentication > - description: DSM Memory region > + - description: DSM Memory region 2 > > required: > - compatible > @@ -63,6 +67,7 @@ allOf: > enum: > - qcom,sm8550-adsp-pas > - qcom,sm8550-cdsp-pas > + - qcom,sm8650-adsp-pas > then: > properties: > interrupts: > @@ -71,7 +76,25 @@ allOf: > maxItems: 5 > memory-region: > maxItems: 2 > - else: > + - if: > + properties: > + compatible: > + enum: > + - qcom,sm8650-cdsp-pas > + then: > + properties: > + interrupts: > + minItems: 5 maxItems > + interrupt-names: > + minItems: 5 maxItems > + memory-region: > + minItems: 3 maxItems: 3 > + - if: > + properties: > + compatible: > + enum: > + - qcom,sm8550-mpss-pas > + then: > properties: > interrupts: > minItems: 6 > @@ -79,12 +102,26 @@ allOf: > minItems: 6 > memory-region: > minItems: 3 You need to add here maxItems. > + - if: > + properties: > + compatible: > + enum: > + - qcom,sm8650-mpss-pas > + then: I am not sure if keeping it in the same binding as sm8550 avoids that much duplication. Best regards, Krzysztof
On 27/10/2023 09:36, Krzysztof Kozlowski wrote: > On 25/10/2023 09:35, Neil Armstrong wrote: >> Document the DSP Peripheral Authentication Service on the SM8650 Platform. >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> .../bindings/remoteproc/qcom,sm8550-pas.yaml | 41 +++++++++++++++++++++- >> 1 file changed, 40 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >> index 58120829fb06..316371c8ee6e 100644 >> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml >> @@ -19,6 +19,9 @@ properties: >> - qcom,sm8550-adsp-pas >> - qcom,sm8550-cdsp-pas >> - qcom,sm8550-mpss-pas >> + - qcom,sm8650-adsp-pas >> + - qcom,sm8650-cdsp-pas >> + - qcom,sm8650-mpss-pas >> >> reg: >> maxItems: 1 >> @@ -49,6 +52,7 @@ properties: >> - description: Memory region for main Firmware authentication >> - description: Memory region for Devicetree Firmware authentication >> - description: DSM Memory region >> + - description: DSM Memory region 2 >> >> required: >> - compatible >> @@ -63,6 +67,7 @@ allOf: >> enum: >> - qcom,sm8550-adsp-pas >> - qcom,sm8550-cdsp-pas >> + - qcom,sm8650-adsp-pas >> then: >> properties: >> interrupts: >> @@ -71,7 +76,25 @@ allOf: >> maxItems: 5 >> memory-region: >> maxItems: 2 >> - else: >> + - if: >> + properties: >> + compatible: >> + enum: >> + - qcom,sm8650-cdsp-pas >> + then: >> + properties: >> + interrupts: >> + minItems: 5 > > maxItems > > >> + interrupt-names: >> + minItems: 5 > > maxItems > >> + memory-region: >> + minItems: 3 > > maxItems: 3 > >> + - if: >> + properties: >> + compatible: >> + enum: >> + - qcom,sm8550-mpss-pas >> + then: >> properties: >> interrupts: >> minItems: 6 >> @@ -79,12 +102,26 @@ allOf: >> minItems: 6 >> memory-region: >> minItems: 3 > > You need to add here maxItems. Ok, I fixed all that > >> + - if: >> + properties: >> + compatible: >> + enum: >> + - qcom,sm8650-mpss-pas >> + then: > > I am not sure if keeping it in the same binding as sm8550 avoids that > much duplication. Yes it does, 70% is the bindings would be the same, still if it's still preferable I can duplicate. Thanks, Neil > > Best regards, > Krzysztof >
On 30/10/2023 09:29, Neil Armstrong wrote: > Ok, I fixed all that > >> >>> + - if: >>> + properties: >>> + compatible: >>> + enum: >>> + - qcom,sm8650-mpss-pas >>> + then: >> >> I am not sure if keeping it in the same binding as sm8550 avoids that >> much duplication. > > Yes it does, 70% is the bindings would be the same, still if it's still preferable I can duplicate. > Then let's keep how you propose - in one binding. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml index 58120829fb06..316371c8ee6e 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml @@ -19,6 +19,9 @@ properties: - qcom,sm8550-adsp-pas - qcom,sm8550-cdsp-pas - qcom,sm8550-mpss-pas + - qcom,sm8650-adsp-pas + - qcom,sm8650-cdsp-pas + - qcom,sm8650-mpss-pas reg: maxItems: 1 @@ -49,6 +52,7 @@ properties: - description: Memory region for main Firmware authentication - description: Memory region for Devicetree Firmware authentication - description: DSM Memory region + - description: DSM Memory region 2 required: - compatible @@ -63,6 +67,7 @@ allOf: enum: - qcom,sm8550-adsp-pas - qcom,sm8550-cdsp-pas + - qcom,sm8650-adsp-pas then: properties: interrupts: @@ -71,7 +76,25 @@ allOf: maxItems: 5 memory-region: maxItems: 2 - else: + - if: + properties: + compatible: + enum: + - qcom,sm8650-cdsp-pas + then: + properties: + interrupts: + minItems: 5 + interrupt-names: + minItems: 5 + memory-region: + minItems: 3 + - if: + properties: + compatible: + enum: + - qcom,sm8550-mpss-pas + then: properties: interrupts: minItems: 6 @@ -79,12 +102,26 @@ allOf: minItems: 6 memory-region: minItems: 3 + - if: + properties: + compatible: + enum: + - qcom,sm8650-mpss-pas + then: + properties: + interrupts: + minItems: 6 + interrupt-names: + minItems: 6 + memory-region: + minItems: 4 - if: properties: compatible: enum: - qcom,sm8550-adsp-pas + - qcom,sm8650-adsp-pas then: properties: power-domains: @@ -101,6 +138,7 @@ allOf: compatible: enum: - qcom,sm8550-mpss-pas + - qcom,sm8650-mpss-pas then: properties: power-domains: @@ -116,6 +154,7 @@ allOf: compatible: enum: - qcom,sm8550-cdsp-pas + - qcom,sm8650-cdsp-pas then: properties: power-domains:
Document the DSP Peripheral Authentication Service on the SM8650 Platform. Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- .../bindings/remoteproc/qcom,sm8550-pas.yaml | 41 +++++++++++++++++++++- 1 file changed, 40 insertions(+), 1 deletion(-)