| Message ID | 20231030222700.18914-2-quic_rajkbhag@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | wifi: ath12k: QCN9274 dualmac bring up | expand |
On 10/30/2023 3:26 PM, Raj Kumar Bhagat wrote: > From: Rajat Soni <quic_rajson@quicinc.com> > > Currently firmware is sending module id as 2 that is not supported. > This causes functional failure in driver. > Firmware added support for WMI_CONFIG_MODULE_CV_UPLOAD. I think the above would be more clearly written as something like: Currently firmware supports sending three different values for enum wmi_direct_buffer_module, but the host currently only supports 2; support for WMI_DIRECT_BUF_CV_UPLOAD is missing. This cause a functional failure on the host because... (what is the problem? the fact that host doesn't allocate buffers for CV upload? or does the value of 2 cause a buffer overread/write of an array sized with WMI_DIRECT_BUFFER_MAX > Add enum WMI_CONFIG_MODULE_CV_UPLOAD in wmi_direct_buffer_module to you actually added WMI_DIRECT_BUF_CV_UPLOAD > resolve this issue. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00188-QCAHKSWPL_SILICONZ-1 > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Rajat Soni <quic_rajson@quicinc.com> > Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com> > --- > drivers/net/wireless/ath/ath12k/wmi.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/ath/ath12k/wmi.h b/drivers/net/wireless/ath/ath12k/wmi.h > index 629373d67..8e1eda7aa 100644 > --- a/drivers/net/wireless/ath/ath12k/wmi.h > +++ b/drivers/net/wireless/ath/ath12k/wmi.h > @@ -2230,6 +2230,7 @@ enum wmi_beacon_gen_mode { > enum wmi_direct_buffer_module { > WMI_DIRECT_BUF_SPECTRAL = 0, > WMI_DIRECT_BUF_CFR = 1, > + WMI_DIRECT_BUF_CV_UPLOAD = 2, > > /* keep it last */ > WMI_DIRECT_BUF_MAX
diff --git a/drivers/net/wireless/ath/ath12k/wmi.h b/drivers/net/wireless/ath/ath12k/wmi.h index 629373d67..8e1eda7aa 100644 --- a/drivers/net/wireless/ath/ath12k/wmi.h +++ b/drivers/net/wireless/ath/ath12k/wmi.h @@ -2230,6 +2230,7 @@ enum wmi_beacon_gen_mode { enum wmi_direct_buffer_module { WMI_DIRECT_BUF_SPECTRAL = 0, WMI_DIRECT_BUF_CFR = 1, + WMI_DIRECT_BUF_CV_UPLOAD = 2, /* keep it last */ WMI_DIRECT_BUF_MAX