| Message ID | 20231202075514.44474-6-tony@atomide.com |
|---|---|
| State | New |
| Headers | show |
| Series | Improvments for tc358775 with support for tc358765 | expand |
On Sat, 2 Dec 2023 at 10:01, Tony Lindgren <tony@atomide.com> wrote: > > From: Michael Walle <mwalle@kernel.org> > > The stby pin is optional. It is only needed for power-up and down > sequencing. It is not needed, if the power rails cannot by dynamically > enabled. > > Because the GPIO is not optional, remove the error message. > > Signed-off-by: Michael Walle <mwalle@kernel.org> > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > drivers/gpu/drm/bridge/tc358775.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> The stby pin is optional. It is only needed for power-up and down > sequencing. It is not needed, if the power rails cannot by dynamically > enabled. > > Because the GPIO is not optional, remove the error message. I just noticed a typo: "is *now* optional. -michael
diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm/bridge/tc358775.c @@ -669,12 +669,9 @@ static int tc_probe(struct i2c_client *client) return ret; } - tc->stby_gpio = devm_gpiod_get(dev, "stby", GPIOD_OUT_HIGH); - if (IS_ERR(tc->stby_gpio)) { - ret = PTR_ERR(tc->stby_gpio); - dev_err(dev, "cannot get stby-gpio %d\n", ret); - return ret; - } + tc->stby_gpio = devm_gpiod_get_optional(dev, "stby", GPIOD_OUT_HIGH); + if (IS_ERR(tc->stby_gpio)) + return PTR_ERR(tc->stby_gpio); tc->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(tc->reset_gpio)) {