| Message ID | 20231225153929.8284-6-maxim.uvarov@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | net fixes prior lwip | expand |
On Mon, Dec 25, 2023 at 3:42 PM Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > > debug print delays reset of the driver. Finally I see > bunch of "rx error FFFF" errors in the screen. CI can > not handle many prints. While network works fine there > > Reproduced with: > make CROSS_COMPILE=sh2-linux- r2dplus_defconfig all > qemu-system-sh4 -M r2d -nographic -serial null \ > -serial mon:stdio -net user,tftp=`pwd` \ > -net nic,model=rtl8139 -kernel ./u-boot.bin > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> > --- > drivers/net/rtl8139.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass <sjg@chromium.org>
diff --git a/drivers/net/rtl8139.c b/drivers/net/rtl8139.c index 106bc1c7ae..d8f24ec81a 100644 --- a/drivers/net/rtl8139.c +++ b/drivers/net/rtl8139.c @@ -453,7 +453,7 @@ static int rtl8139_recv_common(struct rtl8139_priv *priv, unsigned char *rxdata, RTL_STS_RXBADALIGN)) || (rx_size < ETH_ZLEN) || (rx_size > ETH_FRAME_LEN + 4)) { - printf("rx error %hX\n", rx_status); + debug("rx error %hX\n", rx_status); /* this clears all interrupts still pending */ rtl8139_reset(priv); return 0;
debug print delays reset of the driver. Finally I see bunch of "rx error FFFF" errors in the screen. CI can not handle many prints. While network works fine there Reproduced with: make CROSS_COMPILE=sh2-linux- r2dplus_defconfig all qemu-system-sh4 -M r2d -nographic -serial null \ -serial mon:stdio -net user,tftp=`pwd` \ -net nic,model=rtl8139 -kernel ./u-boot.bin Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> --- drivers/net/rtl8139.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)