diff mbox series

v2 test: spmi: fix tests

Message ID 20240108153351.1605918-1-caleb.connolly@linaro.org
State Accepted
Commit 4d6d25be5f7bcdc2d722972bff977aff2f91223c
Headers show
Series v2 test: spmi: fix tests | expand

Commit Message

Caleb Connolly Jan. 8, 2024, 3:31 p.m. UTC 
With the recent changes to the Qualcomm PMIC GPIO driver the sandbox
tests for it no longer pass, update the DTS and tests to work with the
changes.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
---
I'll pick this into qcom-next as it goes along with the PMIC changes there.

V1: lore.kernel.org/u-boot/20240102-b4-pytest-sandbox-spmi-pmic-v1-1-227d1062b3d1@linaro.org
---
 arch/sandbox/dts/test.dts | 2 +-
 test/dm/spmi.c            | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts
index 4fe72664c4b3..e264b29554cf 100644
--- a/arch/sandbox/dts/test.dts
+++ b/arch/sandbox/dts/test.dts
@@ -1544,10 +1544,10 @@ 
 			spmi_gpios: gpios@c000 {
 				compatible = "qcom,pm8916-gpio";
 				reg = <0xc000 0x400>;
+				gpio-ranges = <&spmi_gpios 0 0 4>;
 				gpio-controller;
 				gpio-count = <4>;
 				#gpio-cells = <2>;
-				gpio-bank-name="spmi";
 			};
 		};
 	};
diff --git a/test/dm/spmi.c b/test/dm/spmi.c
index 9cc284b98cb0..97bb0eb30fc9 100644
--- a/test/dm/spmi.c
+++ b/test/dm/spmi.c
@@ -81,7 +81,7 @@  static int dm_test_spmi_access_peripheral(struct unit_test_state *uts)
 	int offset_count;
 
 	/* Get second pin of PMIC GPIO */
-	ut_assertok(gpio_lookup_name("spmi1", &dev, &offset, &gpio));
+	ut_assertok(gpio_lookup_name("pmic1", &dev, &offset, &gpio));
 
 	/* Check if PMIC is parent */
 	ut_asserteq(device_get_uclass_id(dev->parent), UCLASS_PMIC);
@@ -92,7 +92,7 @@  static int dm_test_spmi_access_peripheral(struct unit_test_state *uts)
 	name = gpio_get_bank_info(dev, &offset_count);
 
 	/* Check bank name */
-	ut_asserteq_str("spmi", name);
+	ut_asserteq_str("pmic", name);
 	/* Check pin count */
 	ut_asserteq(4, offset_count);