| Message ID | 20240109194033.909210-1-adhemerval.zanella@linaro.org |
|---|---|
| State | Accepted |
| Commit | 497e4d503025c794a771d2c124123178f557623a |
| Headers | show |
| Series | math: Fix test-fenv.c feupdateenv tests | expand |
The 01/09/2024 16:40, Adhemerval Zanella wrote: > The feupdateenv tests added by 802aef27b2 do not restore the floating > point mask, which might keep some floating point exception enabled and > thus make the feupdateenv_single_test raise an unexpected signal. > > Checked on x86_64-linux-gnu and aarch64-linux-gnu (on Apple M1 trapping > is supported). looks good. Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com> > --- > math/test-fenv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/math/test-fenv.c b/math/test-fenv.c > index 9db6789e64..8d39181b14 100644 > --- a/math/test-fenv.c > +++ b/math/test-fenv.c > @@ -659,6 +659,7 @@ static void > feupdate_single_test (const char *flag_name, int fe_exc) > { > feenv_nomask_test (flag_name, fe_exc, feupdateenv); > + fesetenv (FE_DFL_ENV); > feenv_mask_test (flag_name, fe_exc, feupdateenv); > } > #endif > -- > 2.34.1 >
diff --git a/math/test-fenv.c b/math/test-fenv.c index 9db6789e64..8d39181b14 100644 --- a/math/test-fenv.c +++ b/math/test-fenv.c @@ -659,6 +659,7 @@ static void feupdate_single_test (const char *flag_name, int fe_exc) { feenv_nomask_test (flag_name, fe_exc, feupdateenv); + fesetenv (FE_DFL_ENV); feenv_mask_test (flag_name, fe_exc, feupdateenv); } #endif