| Message ID | 20240109085155.252358-2-hugues.fruchet@foss.st.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v6,1/5] dt-bindings: media: Document STM32MP25 VDEC & VENC video codecs | expand |
Hi Krzysztof, On 1/9/24 22:49, Krzysztof Kozlowski wrote: > On 09/01/2024 09:51, Hugues Fruchet wrote: >> Add STM32MP25 VDEC video decoder & VENC video encoder bindings. >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com> > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > You missed at least devicetree list (maybe more), so this won't be > tested by automated tooling. > > Please kindly resend and include all necessary To/Cc entries. My fault when sending this exact v6, sorry for that.. It was done the right way for previous versions and no issues raised by automated tools. > > While resending drop redundant blank line after SPDX. See all other > bindings and example-schema. I have double checked and I don't see any problem related to redundant blank lines in yaml after SPDX: +++ b/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml @@ -0,0 +1,50 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) + +%YAML 1.2 Could you point me out what is the exact issue ? > > Best regards, > Krzysztof >
On 10/01/2024 10:15, Hugues FRUCHET wrote: >> You missed at least devicetree list (maybe more), so this won't be >> tested by automated tooling. >> >> Please kindly resend and include all necessary To/Cc entries. > > My fault when sending this exact v6, sorry for that.. It was done the > right way for previous versions and no issues raised by automated tools. > >> >> While resending drop redundant blank line after SPDX. See all other >> bindings and example-schema. > I have double checked and I don't see any problem related to redundant > blank lines in yaml after SPDX: I wonder how did you check worked... Open existing other file, open your file. Look at yours. Then look at others. Then again look at yours. > > +++ b/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > + > +%YAML 1.2 > > Could you point me out what is the exact issue ? You have a redundant blank line after SPDX. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml b/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml new file mode 100644 index 000000000000..e167e3b1bec3 --- /dev/null +++ b/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml @@ -0,0 +1,50 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) + +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/st,stm32mp25-video-codec.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: STMicroelectronics STM32MP25 VDEC video decoder & VENC video encoder + +maintainers: + - Hugues Fruchet <hugues.fruchet@foss.st.com> + +description: + The STMicroelectronics STM32MP25 SOCs embeds a VDEC video hardware + decoder peripheral based on Verisilicon VC8000NanoD IP (former Hantro G1) + and a VENC video hardware encoder peripheral based on Verisilicon + VC8000NanoE IP (former Hantro H1). + +properties: + compatible: + enum: + - st,stm32mp25-vdec + - st,stm32mp25-venc + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + - clocks + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + video-codec@580d0000 { + compatible = "st,stm32mp25-vdec"; + reg = <0x580d0000 0x3c8>; + interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ck_icn_p_vdec>; + };