diff mbox series

[v4,1/1] configure.ac: configurable tooldir install path

Message ID 20240111170746.48274-1-neal.frager@amd.com
State Superseded
Headers show
Series [v4,1/1] configure.ac: configurable tooldir install path | expand

Commit Message

Frager, Neal Jan. 11, 2024, 5:07 p.m. UTC 
This patch is required to fix how the newlib headers are installed
when using a sysroot install directory.

The cross compiler expects headers to be in
.../host/usr/arm-none-eabi/sysroot/usr/include/newlib.h
by default newlib installed the headers into
.../host/usr/arm-none-eabi/sysroot/usr/arm-none-eabi/include/newlib.h

${exec_prefix} provides the .../host/usr/arm-none-eabi/sysroot path
${target_noncanonical} provides an extra arm-none-eabi/ that must be removed.

With this patch, users can specify the tooldir path that is needed.

Signed-off-by: Neal Frager <neal.frager@amd.com>
Co-developed-by: Chris Wardman <cjwfirmware@vxmdesign.com>
---
V1->V2:
 - migrated patch to configure.ac
 - changed option name to --with-tooldir=PATH
V2->V3:
 - removed quotes around ${with_tooldir}
V3->V4:
 - migrated case to AS_CASE
 - migrated AC_MSG_WARN to AC_MSG_ERROR
---
 configure.ac | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

Comments

Mike Frysinger Jan. 11, 2024, 5:25 p.m. UTC | #1 
On 11 Jan 2024 17:07, Neal Frager wrote:
> +	[with_tooldir=]

delete this line -- you're erroring out, so there's no need to set it
-mike
diff mbox series

Patch

diff --git a/configure.ac b/configure.ac
index f1bb72100..ae8a0f5b7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2599,7 +2599,16 @@  esac
 
 # Some systems (e.g., one of the i386-aix systems the gas testers are
 # using) don't handle "\$" correctly, so don't use it here.
-tooldir='${exec_prefix}'/${target_noncanonical}
+AC_ARG_WITH([tooldir], 
+  [AS_HELP_STRING([--with-tooldir=PATH],
+		[use given path to install target tools after build])],
+  [AS_CASE([x"$withval"],
+	[x/*],,
+	[with_tooldir=]
+	[AC_MSG_ERROR([argument to --with-tooldir must be an absolute path])])
+  ],
+  [with_tooldir='${exec_prefix}'/${target_noncanonical}])
+tooldir=${with_tooldir}
 build_tooldir=${tooldir}
 
 # Create a .gdbinit file which runs the one in srcdir