| Message ID | 20240122111948.416444-1-romain.naour@smile.fr |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] arch/arm/boot/dts/dra7-l4.dtsi: add missing unit addresse | expand |
Hello, Le 22/01/2024 à 18:11, Conor Dooley a écrit : > On Mon, Jan 22, 2024 at 12:19:46PM +0100, Romain Naour wrote: >> From: Romain Naour <romain.naour@skf.com> >> >> phy_gmii_sel node have 'reg' so it must have unit address. >> >> Fixes: >> Warning (unit_address_vs_reg): /ocp/interconnect@4a000000/segment@0/target-module@2000/scm@0/scm_conf@0/phy-gmii-sel: node has a reg or ranges property, but no unit name > > Does checkpatch not complain about this "Fixes" tag? No, but there is a warning due to the too long line. I removed the Fixes tag. > > Also, for all patches in your series, the subject is odd. Running > `git log` on the files you're changing is a good idea to get off to a > good start with a subject line. You're right. Best regards, Romain > > Thanks, > Conor. > >> >> Signed-off-by: Romain Naour <romain.naour@skf.com>
diff --git a/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi b/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi index 5733e3a4ea8e..6e67d99832ac 100644 --- a/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi +++ b/arch/arm/boot/dts/ti/omap/dra7-l4.dtsi @@ -80,7 +80,7 @@ pbias_mmc_reg: pbias_mmc_omap5 { }; }; - phy_gmii_sel: phy-gmii-sel { + phy_gmii_sel: phy-gmii-sel@554 { compatible = "ti,dra7xx-phy-gmii-sel"; reg = <0x554 0x4>; #phy-cells = <1>;