[v2,02/28] spi: s3c64xx: explicitly include <linux/bits.h>

Message ID	20240125145007.748295-3-tudor.ambarus@linaro.org
State	Superseded
Headers	show Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 333B67316A for <linux-spi@vger.kernel.org>; Thu, 25 Jan 2024 14:50:14 +0000 (UTC) From: Tudor Ambarus <tudor.ambarus@linaro.org> To: broonie@kernel.org, andi.shyti@kernel.org, arnd@arndb.de Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, semen.protsenko@linaro.org, kernel-team@android.com, willmcvicker@google.com, Tudor Ambarus <tudor.ambarus@linaro.org> Subject: [PATCH v2 02/28] spi: s3c64xx: explicitly include <linux/bits.h> Date: Thu, 25 Jan 2024 14:49:40 +0000 Message-ID: <20240125145007.748295-3-tudor.ambarus@linaro.org> In-Reply-To: <20240125145007.748295-1-tudor.ambarus@linaro.org> References: <20240125145007.748295-1-tudor.ambarus@linaro.org> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	spi: s3c64xx: winter cleanup and gs101 support \| expand [v2,00/28] spi: s3c64xx: winter cleanup and gs101 support [v2,01/28] spi: s3c64xx: explicitly include <linux/io.h> [v2,02/28] spi: s3c64xx: explicitly include <linux/bits.h> [v2,03/28] spi: s3c64xx: avoid possible negative array index [v2,04/28] spi: dt-bindings: samsung: add google,gs101-spi compatible [v2,05/28] spi: dt-bindings: samsung: add samsung,spi-fifosize property [v2,06/28] spi: s3c64xx: sort headers alphabetically [v2,07/28] spi: s3c64xx: remove unneeded (void *) casts in of_match_table [v2,08/28] spi: s3c64xx: remove else after return [v2,09/28] spi: s3c64xx: use bitfield access macros [v2,10/28] spi: s3c64xx: use full mask for {RX, TX}_FIFO_LVL [v2,11/28] spi: s3c64xx: move common code outside if else [v2,12/28] spi: s3c64xx: check return code of dmaengine_slave_config() [v2,13/28] spi: s3c64xx: propagate the dma_submit_error() error code [v2,14/28] spi: s3c64xx: rename prepare_dma() to s3c64xx_prepare_dma() [v2,15/28] spi: s3c64xx: return ETIMEDOUT for wait_for_completion_timeout() [v2,16/28] spi: s3c64xx: simplify s3c64xx_wait_for_pio() [v2,17/28] spi: s3c64xx: drop blank line between declarations [v2,18/28] spi: s3c64xx: fix typo, s/configuartion/configuration [v2,19/28] spi: s3c64xx: downgrade dev_warn to dev_dbg for optional dt props [v2,20/28] spi: s3c64xx: add support for inferring fifosize from the compatible [v2,21/28] spi: s3c64xx: infer fifosize from the compatible [v2,22/28] spi: s3c64xx: drop dependency on of_alias where possible [v2,23/28] spi: s3c64xx: retrieve the FIFO size from the device tree [v2,24/28] spi: s3c64xx: mark fifo_lvl_mask as deprecated [v2,25/28] asm-generic/io.h: add iowrite{8,16}_32 accessors [v2,26/28] spi: s3c64xx: add iowrite{8,16}_32_rep accessors [v2,27/28] spi: s3c64xx: add support for google,gs101-spi [v2,28/28] MAINTAINERS: add Tudor Ambarus as R for the samsung SPI driver

Message ID

20240125145007.748295-3-tudor.ambarus@linaro.org

State

Superseded

Headers

From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: broonie@kernel.org,
	andi.shyti@kernel.org,
	arnd@arndb.de
Cc: robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org,
	alim.akhtar@samsung.com,
	linux-spi@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org,
	devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-arch@vger.kernel.org,
	andre.draszik@linaro.org,
	peter.griffin@linaro.org,
	semen.protsenko@linaro.org,
	kernel-team@android.com,
	willmcvicker@google.com,
	Tudor Ambarus <tudor.ambarus@linaro.org>
Subject: [PATCH v2 02/28] spi: s3c64xx: explicitly include <linux/bits.h>
Date: Thu, 25 Jan 2024 14:49:40 +0000
Message-ID: <20240125145007.748295-3-tudor.ambarus@linaro.org>
In-Reply-To: <20240125145007.748295-1-tudor.ambarus@linaro.org>
References: <20240125145007.748295-1-tudor.ambarus@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

spi: s3c64xx: winter cleanup and gs101 support | expand

Commit Message

Tudor Ambarus Jan. 25, 2024, 2:49 p.m. UTC

The driver uses GENMASK() but does not include <linux/bits.h>.

It is good practice to directly include all headers used, it avoids
implicit dependencies and spurious breakage if someone rearranges
headers and causes the implicit include to vanish.

Include the missing header.

Fixes: 1224e29572f6 ("spi: s3c64xx: Fix large transfers with DMA")
Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
 drivers/spi/spi-s3c64xx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index c1cbc4780a3b..2b5bb7604526 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -3,6 +3,7 @@ 
 // Copyright (c) 2009 Samsung Electronics Co., Ltd.
 //      Jaswinder Singh <jassi.brar@samsung.com>
 
+#include <linux/bits.h>
 #include <linux/init.h>
 #include <linux/module.h>
 #include <linux/interrupt.h>

[v2,02/28] spi: s3c64xx: explicitly include <linux/bits.h>

Commit Message

Patch