diff mbox

[v2,3/9] new: blacklist.tsan

Message ID 20160922101316.13064-4-alex.bennee@linaro.org
State New
Headers show

Commit Message

Alex Bennée Sept. 22, 2016, 10:13 a.m. UTC
A list of blacklists for tsan instrumentation. One hopes more can be
removed over time as tsan improves.

The path needs to be absolute so it doesn't break when directories
change during the build:

  ./configure --with-coroutine=gthread --disable-pie \
    --extra-cflags="-g3 -O0 -fsanitize=thread \
    -fsanitize-blacklist=/home/alex/lsrc/qemu/qemu.git/blacklist.tsan"

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

---
 blacklist.tsan | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 blacklist.tsan

-- 
2.9.3

Comments

Alex Bennée Sept. 22, 2016, 2:11 p.m. UTC | #1
Eric Blake <eblake@redhat.com> writes:

> On 09/22/2016 05:13 AM, Alex Bennée wrote:

>> A list of blacklists for tsan instrumentation. One hopes more can be

>> removed over time as tsan improves.

>

> A list of one file? It sounds like this sentence is stale, from an

> earlier revision where the blacklist was longer.


When I was going through the compiler failures and added the first one I
assumed more would be needed ;-)

>

>>

>> The path needs to be absolute so it doesn't break when directories

>> change during the build:

>>

>>   ./configure --with-coroutine=gthread --disable-pie \

>>     --extra-cflags="-g3 -O0 -fsanitize=thread \

>>     -fsanitize-blacklist=/home/alex/lsrc/qemu/qemu.git/blacklist.tsan"

>>

>

> Is there any way to make configure automatically convert a relative name

> into an absolute?


We could teach configure about the sanitizers and embed the knowledge
there.

>

>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

>> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

>> ---

>>  blacklist.tsan | 2 ++

>>  1 file changed, 2 insertions(+)

>>  create mode 100644 blacklist.tsan

>>

>> diff --git a/blacklist.tsan b/blacklist.tsan

>> new file mode 100644

>> index 0000000..9e53a84

>> --- /dev/null

>> +++ b/blacklist.tsan

>> @@ -0,0 +1,2 @@

>> +# the vector intrinsics upset tsan

>> +src:bufferiszero.c

>>



--
Alex Bennée
diff mbox

Patch

diff --git a/blacklist.tsan b/blacklist.tsan
new file mode 100644
index 0000000..9e53a84
--- /dev/null
+++ b/blacklist.tsan
@@ -0,0 +1,2 @@ 
+# the vector intrinsics upset tsan
+src:bufferiszero.c