diff mbox series

dt-bindings: leds: Add LED_FUNCTION_WAN_ONLINE for Internet access

Message ID 20240223112223.1368-1-zajec5@gmail.com
State New
Headers show
Series dt-bindings: leds: Add LED_FUNCTION_WAN_ONLINE for Internet access | expand

Commit Message

Rafał Miłecki Feb. 23, 2024, 11:22 a.m. UTC 
From: Rafał Miłecki <rafal@milecki.pl>

It's common for routers to have LED indicating link on the WAN port.

Some devices however have an extra LED that's meant to be used if WAN
connection is actually "online" (there is Internet access available).

It was suggested to add #define for such use case.

Link: https://lore.kernel.org/linux-devicetree/80e92209-5578-44e7-bd4b-603a29053ddf@collabora.com/T/#u
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 include/dt-bindings/leds/common.h | 1 +
 1 file changed, 1 insertion(+)

Comments

AngeloGioacchino Del Regno Feb. 26, 2024, 12:28 p.m. UTC | #1 
Il 23/02/24 12:22, Rafał Miłecki ha scritto:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> It's common for routers to have LED indicating link on the WAN port.
> 
> Some devices however have an extra LED that's meant to be used if WAN
> connection is actually "online" (there is Internet access available).
> 
> It was suggested to add #define for such use case.

In this case, you can use the Suggested-by tag, but I'm not picky anyway :-)

> 
> Link: https://lore.kernel.org/linux-devicetree/80e92209-5578-44e7-bd4b-603a29053ddf@collabora.com/T/#u
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Lee Jones Feb. 29, 2024, 5:18 p.m. UTC | #2 
On Fri, 23 Feb 2024 12:22:23 +0100, Rafał Miłecki wrote:
> It's common for routers to have LED indicating link on the WAN port.
> 
> Some devices however have an extra LED that's meant to be used if WAN
> connection is actually "online" (there is Internet access available).
> 
> It was suggested to add #define for such use case.
> 
> [...]

Applied, thanks!

[1/1] dt-bindings: leds: Add LED_FUNCTION_WAN_ONLINE for Internet access
      commit: c0ef9799df8756968c236720658e492fbe636064

--
Lee Jones [李琼斯]
Linus Walleij March 3, 2024, 7:41 p.m. UTC | #3 
On Fri, Feb 23, 2024 at 12:22 PM Rafał Miłecki <zajec5@gmail.com> wrote:

> From: Rafał Miłecki <rafal@milecki.pl>
>
> It's common for routers to have LED indicating link on the WAN port.
>
> Some devices however have an extra LED that's meant to be used if WAN
> connection is actually "online" (there is Internet access available).
>
> It was suggested to add #define for such use case.
>
> Link: https://lore.kernel.org/linux-devicetree/80e92209-5578-44e7-bd4b-603a29053ddf@collabora.com/T/#u
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

That looks helpful.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
index c56785bb9c9c..ecea167930d9 100644
--- a/include/dt-bindings/leds/common.h
+++ b/include/dt-bindings/leds/common.h
@@ -100,6 +100,7 @@ 
 #define LED_FUNCTION_TX "tx"
 #define LED_FUNCTION_USB "usb"
 #define LED_FUNCTION_WAN "wan"
+#define LED_FUNCTION_WAN_ONLINE "wan-online"
 #define LED_FUNCTION_WLAN "wlan"
 #define LED_FUNCTION_WLAN_2GHZ "wlan-2ghz"
 #define LED_FUNCTION_WLAN_5GHZ "wlan-5ghz"