| Message ID | 20240225120350.31226-1-bergh.jonathan@gmail.com |
|---|---|
| State | Accepted |
| Commit | ab8504731611b2cb9de156cae617139ef751e056 |
| Headers | show |
| Series | staging: media: atomisp: Fix various formatting issues and remove unneccesary braces | expand |
Hi Jonathan, On 2/25/24 13:03, Jonathan Bergh wrote: > This patch fixes the following formatting issues: > * Fix various misaligned * and */ in multiline block comments > * Remove unnecessary braces from single line conditional statements > * Remove repeated word "from" from comment > > Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> (I'll apply this to my atomisp-branch the next time I'm working on that branch). Regards, Hans > --- > drivers/staging/media/atomisp/pci/atomisp_cmd.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c > index d0db2efe0045..5fa9918c8e1e 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c > @@ -65,7 +65,8 @@ > * At 15fps this means 133ms. We set the timeout a bit longer. > * Each flash driver is supposed to set its own timeout, but > * just in case someone else changed the timeout, we set it > - * here to make sure we don't damage the flash hardware. */ > + * here to make sure we don't damage the flash hardware. > + */ > #define FLASH_TIMEOUT 800 /* ms */ > > union host { > @@ -1261,11 +1262,10 @@ int atomisp_gdc_cac(struct atomisp_sub_device *asd, int flag, > } > > asd->params.gdc_cac_en = !!*value; > - if (asd->params.gdc_cac_en) { > + if (asd->params.gdc_cac_en) > asd->params.config.morph_table = asd->params.css_param.morph_table; > - } else { > + else > asd->params.config.morph_table = NULL; > - } > asd->params.css_update_params_needed = true; > atomisp_update_capture_mode(asd); > return 0; > @@ -3035,8 +3035,8 @@ void atomisp_handle_parameter_and_buffer(struct atomisp_video_pipe *pipe) > } > > /* > -* Function to configure ISP parameters > -*/ > + * Function to configure ISP parameters > + */ > int atomisp_set_parameters(struct video_device *vdev, > struct atomisp_parameters *arg) > { > @@ -3367,7 +3367,7 @@ int atomisp_fixed_pattern(struct atomisp_sub_device *asd, int flag, > return 0; > } > > - /* Add function to get black from from sensor with shutter off */ > + /* Add function to get black from sensor with shutter off */ > return 0; > } >
diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c index d0db2efe0045..5fa9918c8e1e 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c @@ -65,7 +65,8 @@ * At 15fps this means 133ms. We set the timeout a bit longer. * Each flash driver is supposed to set its own timeout, but * just in case someone else changed the timeout, we set it - * here to make sure we don't damage the flash hardware. */ + * here to make sure we don't damage the flash hardware. + */ #define FLASH_TIMEOUT 800 /* ms */ union host { @@ -1261,11 +1262,10 @@ int atomisp_gdc_cac(struct atomisp_sub_device *asd, int flag, } asd->params.gdc_cac_en = !!*value; - if (asd->params.gdc_cac_en) { + if (asd->params.gdc_cac_en) asd->params.config.morph_table = asd->params.css_param.morph_table; - } else { + else asd->params.config.morph_table = NULL; - } asd->params.css_update_params_needed = true; atomisp_update_capture_mode(asd); return 0; @@ -3035,8 +3035,8 @@ void atomisp_handle_parameter_and_buffer(struct atomisp_video_pipe *pipe) } /* -* Function to configure ISP parameters -*/ + * Function to configure ISP parameters + */ int atomisp_set_parameters(struct video_device *vdev, struct atomisp_parameters *arg) { @@ -3367,7 +3367,7 @@ int atomisp_fixed_pattern(struct atomisp_sub_device *asd, int flag, return 0; } - /* Add function to get black from from sensor with shutter off */ + /* Add function to get black from sensor with shutter off */ return 0; }
This patch fixes the following formatting issues: * Fix various misaligned * and */ in multiline block comments * Remove unnecessary braces from single line conditional statements * Remove repeated word "from" from comment Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com> --- drivers/staging/media/atomisp/pci/atomisp_cmd.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)