diff mbox

[2/2] libfdt: fix fdt_stringlist_search()

Message ID 1476685470-4372-3-git-send-email-yamada.masahiro@socionext.com
State Superseded
Headers show

Commit Message

Masahiro Yamada Oct. 17, 2016, 6:24 a.m. UTC 
If fdt_getprop() fails, negative error code should be returned.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

---

 lib/libfdt/fdt_ro.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.1

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Comments

Simon Glass Oct. 17, 2016, 10:17 p.m. UTC | #1 
On 17 October 2016 at 00:24, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> If fdt_getprop() fails, negative error code should be returned.

>

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

> ---

>

>  lib/libfdt/fdt_ro.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)


Acked-by: Simon Glass <sjg@chromium.org>

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
diff mbox

Patch

diff --git a/lib/libfdt/fdt_ro.c b/lib/libfdt/fdt_ro.c
index fc08981..1be9538 100644
--- a/lib/libfdt/fdt_ro.c
+++ b/lib/libfdt/fdt_ro.c
@@ -576,7 +576,7 @@  int fdt_stringlist_search(const void *fdt, int nodeoffset, const char *property,
 
 	list = fdt_getprop(fdt, nodeoffset, property, &length);
 	if (!list)
-		return -length;
+		return length;
 
 	len = strlen(string) + 1;
 	end = list + length;