| Message ID | 20240307203015.870254-2-bvanassche@acm.org |
|---|---|
| State | New |
| Headers | show |
| Series | scsi_debug improvements | expand |
On 07/03/2024 20:30, Bart Van Assche wrote: > Commit f1437cd1e535 ("scsi: scsi_debug: Drop sdebug_queue") removed > the 'in_use_bm' struct member. Hence remove a reference to that struct > member from the procfs host info file. > > Cc: Douglas Gilbert<dgilbert@interlog.com> > Cc: John Garry<john.g.garry@oracle.com> > Fixes: f1437cd1e535 ("scsi: scsi_debug: Drop sdebug_queue") > Signed-off-by: Bart Van Assche<bvanassche@acm.org> Reviewed-by: John Garry <john.g.garry@oracle.com> > --- > drivers/scsi/scsi_debug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c > index acf0592d63da..36368c71221b 100644 > --- a/drivers/scsi/scsi_debug.c > +++ b/drivers/scsi/scsi_debug.c > @@ -6516,7 +6516,7 @@ static int scsi_debug_show_info(struct seq_file *m, struct Scsi_Host *host) > blk_mq_tagset_busy_iter(&host->tag_set, sdebug_submit_queue_iter, > &data); > if (f >= 0) { > - seq_printf(m, " in_use_bm BUSY: %s: %d,%d\n", > + seq_printf(m, " BUSY: %s: %d,%d\n", > "first,last bits", f, l); maybe this can fit on a single line now without exceeding 80 char (which some people still want - I don't mind). Thanks, John
On 3/8/24 03:46, John Garry wrote: > On 07/03/2024 20:30, Bart Van Assche wrote: >> Commit f1437cd1e535 ("scsi: scsi_debug: Drop sdebug_queue") removed >> the 'in_use_bm' struct member. Hence remove a reference to that struct >> member from the procfs host info file. >> >> Cc: Douglas Gilbert<dgilbert@interlog.com> >> Cc: John Garry<john.g.garry@oracle.com> >> Fixes: f1437cd1e535 ("scsi: scsi_debug: Drop sdebug_queue") >> Signed-off-by: Bart Van Assche<bvanassche@acm.org> > > Reviewed-by: John Garry <john.g.garry@oracle.com> > >> --- >> drivers/scsi/scsi_debug.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c >> index acf0592d63da..36368c71221b 100644 >> --- a/drivers/scsi/scsi_debug.c >> +++ b/drivers/scsi/scsi_debug.c >> @@ -6516,7 +6516,7 @@ static int scsi_debug_show_info(struct seq_file >> *m, struct Scsi_Host *host) >> blk_mq_tagset_busy_iter(&host->tag_set, >> sdebug_submit_queue_iter, >> &data); >> if (f >= 0) { >> - seq_printf(m, " in_use_bm BUSY: %s: %d,%d\n", >> + seq_printf(m, " BUSY: %s: %d,%d\n", >> "first,last bits", f, l); > > maybe this can fit on a single line now without exceeding 80 char (which > some people still want - I don't mind). The most compact version of this patch I can come up with is the following: @@ -6384,8 +6384,8 @@ static int scsi_debug_show_info(struct seq_file *m, struct Scsi_Host *host) blk_mq_tagset_busy_iter(&host->tag_set, sdebug_submit_queue_iter, &data); if (f >= 0) { - seq_printf(m, " in_use_bm BUSY: %s: %d,%d\n", - "first,last bits", f, l); + seq_printf(m, " BUSY: first,last bits: %d,%d\n", f, + l); } } Thanks, Bart.
diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c index acf0592d63da..36368c71221b 100644 --- a/drivers/scsi/scsi_debug.c +++ b/drivers/scsi/scsi_debug.c @@ -6516,7 +6516,7 @@ static int scsi_debug_show_info(struct seq_file *m, struct Scsi_Host *host) blk_mq_tagset_busy_iter(&host->tag_set, sdebug_submit_queue_iter, &data); if (f >= 0) { - seq_printf(m, " in_use_bm BUSY: %s: %d,%d\n", + seq_printf(m, " BUSY: %s: %d,%d\n", "first,last bits", f, l); } }
Commit f1437cd1e535 ("scsi: scsi_debug: Drop sdebug_queue") removed the 'in_use_bm' struct member. Hence remove a reference to that struct member from the procfs host info file. Cc: Douglas Gilbert <dgilbert@interlog.com> Cc: John Garry <john.g.garry@oracle.com> Fixes: f1437cd1e535 ("scsi: scsi_debug: Drop sdebug_queue") Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- drivers/scsi/scsi_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)