| Message ID | 20161018110725.28585-1-lersek@redhat.com |
|---|---|
| State | Accepted |
| Commit | 09bd67f09573ad5a40875f3d7bfbf49c43756cf5 |
| Headers | show |
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com> > -----Original Message----- > From: Tim Lewis [mailto:tim.lewis@insyde.com] > Sent: Tuesday, October 18, 2016 5:44 AM > To: Laszlo Ersek <lersek@redhat.com>; edk2-devel-01 <edk2- > devel@ml01.01.org> > Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com> > Subject: RE: [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in > EfiShellGetGuidFromName() > Importance: High > > Reviewed-by: Tim Lewis <tim.lewis@insyde.com> > > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Tuesday, October 18, 2016 4:07 AM > To: edk2-devel-01 <edk2-devel@ml01.01.org> > Cc: Jaben Carsey <jaben.carsey@intel.com>; Ruiyu Ni <ruiyu.ni@intel.com>; > Tim Lewis <tim.lewis@insyde.com> > Subject: [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in > EfiShellGetGuidFromName() > > The destination GUID comes first; from > "MdePkg/Include/Library/BaseMemoryLib.h": > > > GUID * > > EFIAPI > > CopyGuid ( > > OUT GUID *DestinationGuid, > > IN CONST GUID *SourceGuid > > ); > > Here "NewGuid" is the GUID looked up by GetGuidFromStringName(), and > "Guid" is where EfiShellGetGuidFromName() has to propagate that result to. > > Cc: Jaben Carsey <jaben.carsey@intel.com> > Cc: Ruiyu Ni <ruiyu.ni@intel.com> > Cc: Tim Lewis <tim.lewis@insyde.com> > Reported-by: Tim Lewis <tim.lewis@insyde.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek <lersek@redhat.com> > --- > ShellPkg/Application/Shell/ShellProtocol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ShellPkg/Application/Shell/ShellProtocol.c > b/ShellPkg/Application/Shell/ShellProtocol.c > index 2bc0646b453d..04b66c5acaae 100644 > --- a/ShellPkg/Application/Shell/ShellProtocol.c > +++ b/ShellPkg/Application/Shell/ShellProtocol.c > @@ -2207,7 +2207,7 @@ EfiShellGetGuidFromName( > Status = GetGuidFromStringName(GuidName, NULL, &NewGuid); > > if (!EFI_ERROR(Status)) { > - CopyGuid(NewGuid, Guid); > + CopyGuid(Guid, NewGuid); > } > > return (Status); > -- > 2.9.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On 10/18/16 16:54, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey <jaben.carsey@intel.com> > >> -----Original Message----- >> From: Tim Lewis [mailto:tim.lewis@insyde.com] >> Sent: Tuesday, October 18, 2016 5:44 AM >> To: Laszlo Ersek <lersek@redhat.com>; edk2-devel-01 <edk2- >> devel@ml01.01.org> >> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com> >> Subject: RE: [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in >> EfiShellGetGuidFromName() >> Importance: High >> >> Reviewed-by: Tim Lewis <tim.lewis@insyde.com> Commit 09bd67f09573. Thanks! Laszlo >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Tuesday, October 18, 2016 4:07 AM >> To: edk2-devel-01 <edk2-devel@ml01.01.org> >> Cc: Jaben Carsey <jaben.carsey@intel.com>; Ruiyu Ni <ruiyu.ni@intel.com>; >> Tim Lewis <tim.lewis@insyde.com> >> Subject: [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in >> EfiShellGetGuidFromName() >> >> The destination GUID comes first; from >> "MdePkg/Include/Library/BaseMemoryLib.h": >> >>> GUID * >>> EFIAPI >>> CopyGuid ( >>> OUT GUID *DestinationGuid, >>> IN CONST GUID *SourceGuid >>> ); >> >> Here "NewGuid" is the GUID looked up by GetGuidFromStringName(), and >> "Guid" is where EfiShellGetGuidFromName() has to propagate that result to. >> >> Cc: Jaben Carsey <jaben.carsey@intel.com> >> Cc: Ruiyu Ni <ruiyu.ni@intel.com> >> Cc: Tim Lewis <tim.lewis@insyde.com> >> Reported-by: Tim Lewis <tim.lewis@insyde.com> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Laszlo Ersek <lersek@redhat.com> >> --- >> ShellPkg/Application/Shell/ShellProtocol.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ShellPkg/Application/Shell/ShellProtocol.c >> b/ShellPkg/Application/Shell/ShellProtocol.c >> index 2bc0646b453d..04b66c5acaae 100644 >> --- a/ShellPkg/Application/Shell/ShellProtocol.c >> +++ b/ShellPkg/Application/Shell/ShellProtocol.c >> @@ -2207,7 +2207,7 @@ EfiShellGetGuidFromName( >> Status = GetGuidFromStringName(GuidName, NULL, &NewGuid); >> >> if (!EFI_ERROR(Status)) { >> - CopyGuid(NewGuid, Guid); >> + CopyGuid(Guid, NewGuid); >> } >> >> return (Status); >> -- >> 2.9.2 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/ShellPkg/Application/Shell/ShellProtocol.c b/ShellPkg/Application/Shell/ShellProtocol.c index 2bc0646b453d..04b66c5acaae 100644 --- a/ShellPkg/Application/Shell/ShellProtocol.c +++ b/ShellPkg/Application/Shell/ShellProtocol.c @@ -2207,7 +2207,7 @@ EfiShellGetGuidFromName( Status = GetGuidFromStringName(GuidName, NULL, &NewGuid); if (!EFI_ERROR(Status)) { - CopyGuid(NewGuid, Guid); + CopyGuid(Guid, NewGuid); } return (Status);