| Message ID | 20240313194318.1397153-1-luiz.dentz@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v1] Bluetooth: ISO: Don't reject BT_ISO_QOS if parameters are unset | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=835082 ---Test result--- Test Summary: CheckPatch PASS 0.46 seconds GitLint PASS 0.18 seconds SubjectPrefix PASS 0.05 seconds BuildKernel PASS 27.83 seconds CheckAllWarning PASS 31.07 seconds CheckSparse PASS 36.62 seconds CheckSmatch PASS 98.60 seconds BuildKernel32 PASS 27.05 seconds TestRunnerSetup PASS 512.43 seconds TestRunner_l2cap-tester PASS 18.05 seconds TestRunner_iso-tester FAIL 31.24 seconds TestRunner_bnep-tester PASS 4.91 seconds TestRunner_mgmt-tester PASS 108.55 seconds TestRunner_rfcomm-tester PASS 7.44 seconds TestRunner_sco-tester PASS 14.93 seconds TestRunner_ioctl-tester PASS 7.78 seconds TestRunner_mesh-tester PASS 5.88 seconds TestRunner_smp-tester PASS 6.89 seconds TestRunner_userchan-tester PASS 4.94 seconds IncrementalBuild PASS 28.37 seconds Details ############################## Test: TestRunner_iso-tester - FAIL Desc: Run iso-tester with test-runner Output: Total: 117, Passed: 116 (99.1%), Failed: 1, Not Run: 0 Failed Test Cases ISO Connect Suspend - Success Failed 4.188 seconds --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Wed, 13 Mar 2024 15:43:18 -0400 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > Consider certain values (0x00) as unset and load proper default if > an application has not set them properly. > > Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > [...] Here is the summary with links: - [v1] Bluetooth: ISO: Don't reject BT_ISO_QOS if parameters are unset https://git.kernel.org/bluetooth/bluetooth-next/c/60482ab92867 You are awesome, thank you!
diff --git a/net/bluetooth/iso.c b/net/bluetooth/iso.c index c8793e57f4b5..d24148ea883c 100644 --- a/net/bluetooth/iso.c +++ b/net/bluetooth/iso.c @@ -1451,8 +1451,8 @@ static bool check_ucast_qos(struct bt_iso_qos *qos) static bool check_bcast_qos(struct bt_iso_qos *qos) { - if (qos->bcast.sync_factor == 0x00) - return false; + if (!qos->bcast.sync_factor) + qos->bcast.sync_factor = 0x01; if (qos->bcast.packing > 0x01) return false; @@ -1475,6 +1475,9 @@ static bool check_bcast_qos(struct bt_iso_qos *qos) if (qos->bcast.skip > 0x01f3) return false; + if (!qos->bcast.sync_timeout) + qos->bcast.sync_timeout = BT_ISO_SYNC_TIMEOUT; + if (qos->bcast.sync_timeout < 0x000a || qos->bcast.sync_timeout > 0x4000) return false; @@ -1484,6 +1487,9 @@ static bool check_bcast_qos(struct bt_iso_qos *qos) if (qos->bcast.mse > 0x1f) return false; + if (!qos->bcast.timeout) + qos->bcast.sync_timeout = BT_ISO_SYNC_TIMEOUT; + if (qos->bcast.timeout < 0x000a || qos->bcast.timeout > 0x4000) return false;