| Message ID | 20240321232023.2064975-1-edliaw@google.com |
|---|---|
| State | Accepted |
| Commit | 105840ebd76d8dbc1a7d734748ae320076f3201e |
| Headers | show |
| Series | [v1] selftests/mm: sigbus-wp test requires UFFD_FEATURE_WP_HUGETLBFS_SHMEM | expand |
On Thu, 21 Mar 2024 23:20:21 +0000 Edward Liaw <edliaw@google.com> wrote: > The sigbus-wp test requires the UFFD_FEATURE_WP_HUGETLBFS_SHMEM flag for > shmem and hugetlb targets. Otherwise it is not backwards compatible > with kernels <5.19 and fails with EINVAL. > > ... > > --- a/tools/testing/selftests/mm/uffd-unit-tests.c > +++ b/tools/testing/selftests/mm/uffd-unit-tests.c > @@ -1437,7 +1437,8 @@ uffd_test_case_t uffd_tests[] = { > .uffd_fn = uffd_sigbus_wp_test, > .mem_targets = MEM_ALL, > .uffd_feature_required = UFFD_FEATURE_SIGBUS | > - UFFD_FEATURE_EVENT_FORK | UFFD_FEATURE_PAGEFAULT_FLAG_WP, > + UFFD_FEATURE_EVENT_FORK | UFFD_FEATURE_PAGEFAULT_FLAG_WP | > + UFFD_FEATURE_WP_HUGETLBFS_SHMEM, > }, > { > .name = "events", Thanks, I'll add Fixes: 73c1ea939b65 ("selftests/mm: move uffd sig/events tests into uffd unit tests") Cc: <stable@vger.kernel.org>
diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/selftests/mm/uffd-unit-tests.c index 4a48dc617c6b..21ec23206ab4 100644 --- a/tools/testing/selftests/mm/uffd-unit-tests.c +++ b/tools/testing/selftests/mm/uffd-unit-tests.c @@ -1437,7 +1437,8 @@ uffd_test_case_t uffd_tests[] = { .uffd_fn = uffd_sigbus_wp_test, .mem_targets = MEM_ALL, .uffd_feature_required = UFFD_FEATURE_SIGBUS | - UFFD_FEATURE_EVENT_FORK | UFFD_FEATURE_PAGEFAULT_FLAG_WP, + UFFD_FEATURE_EVENT_FORK | UFFD_FEATURE_PAGEFAULT_FLAG_WP | + UFFD_FEATURE_WP_HUGETLBFS_SHMEM, }, { .name = "events",
The sigbus-wp test requires the UFFD_FEATURE_WP_HUGETLBFS_SHMEM flag for shmem and hugetlb targets. Otherwise it is not backwards compatible with kernels <5.19 and fails with EINVAL. Signed-off-by: Edward Liaw <edliaw@google.com> --- tools/testing/selftests/mm/uffd-unit-tests.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)