| Message ID | 20240405-cdns-qspi-mbly-v2-2-956679866d6d@bootlin.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | spi: cadence-qspi: add Mobileye EyeQ5 support | expand |
On 05/04/2024 17:02, Théo Lebrun wrote: > Compatibles are ordered by date of addition. > Switch to (deterministic) alphabetical ordering. > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > --- > Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, Apr 05, 2024 at 05:02:12PM +0200, Théo Lebrun wrote: > Compatibles are ordered by date of addition. > Switch to (deterministic) alphabetical ordering. > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > --- > Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > index 5509c126b1cf..e53d443c6f93 100644 > --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > @@ -79,13 +79,13 @@ properties: > - items: > - enum: > - amd,pensando-elba-qspi > - - mobileye,eyeq5-ospi > - - ti,k2g-qspi > - - ti,am654-ospi > - intel,lgm-qspi > - - xlnx,versal-ospi-1.0 > - intel,socfpga-qspi > + - mobileye,eyeq5-ospi > - starfive,jh7110-qspi > + - ti,am654-ospi > + - ti,k2g-qspi > + - xlnx,versal-ospi-1.0 In general it's better to sort trivial cleanup patches like this before new functionality in order to avoid spurious dependencies.
Hello, On Mon Apr 8, 2024 at 4:14 PM CEST, Mark Brown wrote: > On Fri, Apr 05, 2024 at 05:02:12PM +0200, Théo Lebrun wrote: > > Compatibles are ordered by date of addition. > > Switch to (deterministic) alphabetical ordering. > > > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > > --- > > Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > > index 5509c126b1cf..e53d443c6f93 100644 > > --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > > +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > > @@ -79,13 +79,13 @@ properties: > > - items: > > - enum: > > - amd,pensando-elba-qspi > > - - mobileye,eyeq5-ospi > > - - ti,k2g-qspi > > - - ti,am654-ospi > > - intel,lgm-qspi > > - - xlnx,versal-ospi-1.0 > > - intel,socfpga-qspi > > + - mobileye,eyeq5-ospi > > - starfive,jh7110-qspi > > + - ti,am654-ospi > > + - ti,k2g-qspi > > + - xlnx,versal-ospi-1.0 > > In general it's better to sort trivial cleanup patches like this before > new functionality in order to avoid spurious dependencies. It wasn't clear to me if this patch was desired. I therefore put it afterwards to avoid conflicts if "spi: dt-bindings: cdns,qspi-nor: add mobileye,eyeq5-ospi compatible" was applied. Now that I know it is desired, I'll move it first in the series. Thanks, -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml index 5509c126b1cf..e53d443c6f93 100644 --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml @@ -79,13 +79,13 @@ properties: - items: - enum: - amd,pensando-elba-qspi - - mobileye,eyeq5-ospi - - ti,k2g-qspi - - ti,am654-ospi - intel,lgm-qspi - - xlnx,versal-ospi-1.0 - intel,socfpga-qspi + - mobileye,eyeq5-ospi - starfive,jh7110-qspi + - ti,am654-ospi + - ti,k2g-qspi + - xlnx,versal-ospi-1.0 - const: cdns,qspi-nor - const: cdns,qspi-nor
Compatibles are ordered by date of addition. Switch to (deterministic) alphabetical ordering. Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> --- Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)