| Message ID | 20240411200305.183703-1-luiz.dentz@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [BlueZ,v4,1/4] shared/bap: Fix not updating location | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=843758 ---Test result--- Test Summary: CheckPatch PASS 1.85 seconds GitLint FAIL 1.44 seconds BuildEll PASS 25.04 seconds BluezMake PASS 1714.50 seconds MakeCheck PASS 13.76 seconds MakeDistcheck PASS 179.88 seconds CheckValgrind PASS 249.74 seconds CheckSmatch WARNING 354.55 seconds bluezmakeextell PASS 121.59 seconds IncrementalBuild PASS 6157.17 seconds ScanBuild PASS 996.33 seconds Details ############################## Test: GitLint - FAIL Desc: Run gitlint Output: [BlueZ,v4,2/4] shared/bap: Make bt_bap_select fallback in case of no channel allocation WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 1: T1 Title exceeds max length (87>80): "[BlueZ,v4,2/4] shared/bap: Make bt_bap_select fallback in case of no channel allocation" ############################## Test: CheckSmatch - WARNING Desc: Run smatch tool with source Output: src/shared/bap.c:282:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:282:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:282:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:282:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:282:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:282:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:282:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:282:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:282:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structures --- Regards, Linux Bluetooth
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Thu, 11 Apr 2024 16:03:02 -0400 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > Fix not updating map.location when selecting. > --- > src/shared/bap.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Here is the summary with links: - [BlueZ,v4,1/4] shared/bap: Fix not updating location https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=be79cd19c5c5 - [BlueZ,v4,2/4] shared/bap: Make bt_bap_select fallback in case of no channel allocation https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c7dcd064057f - [BlueZ,v4,3/4] shared/bap: Fix not resuming reading attributes https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=7db85520b76d - [BlueZ,v4,4/4] bap: Update properties of endpoints https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=9be5d8018dd1 You are awesome, thank you!
diff --git a/src/shared/bap.c b/src/shared/bap.c index f553096dfcc6..b452461ac715 100644 --- a/src/shared/bap.c +++ b/src/shared/bap.c @@ -5163,12 +5163,10 @@ int bt_bap_select(struct bt_bap_pac *lpac, struct bt_bap_pac *rpac, /* Check if there are any channels left to select */ map.count &= ~(map.count & rc->count); - if (!map.count) - break; - /* Check if there are any locations left to select */ map.location &= ~(map.location & rc->location); - if (!map.location) + + if (!map.count || !map.location) break; /* Check if device require AC*(i) settings */
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Fix not updating map.location when selecting. --- src/shared/bap.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)