| Message ID | 20240423121322.28460-4-wsa+renesas@sang-engineering.com |
|---|---|
| State | New |
| Headers | show |
| Series | i2c: remove printout on handled timeouts - part 2 | expand |
On Tue, 23 Apr 2024 14:13:20 +0200, Wolfram Sang wrote: > I2C and SMBus timeouts are not something the user needs to be informed > about on controller level. The client driver may know if that really is > a problem and give more detailed information to the user. The controller > should just pass this information upwards. Remove the printout. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > drivers/i2c/busses/i2c-ali1563.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-ali1563.c b/drivers/i2c/busses/i2c-ali1563.c > index 307fb0666ecb..63897a89bb35 100644 > --- a/drivers/i2c/busses/i2c-ali1563.c > +++ b/drivers/i2c/busses/i2c-ali1563.c > @@ -99,7 +99,6 @@ static int ali1563_transaction(struct i2c_adapter *a, int size) > return 0; > > if (!timeout) { > - dev_err(&a->dev, "Timeout - Trying to KILL transaction!\n"); > /* Issue 'kill' to host controller */ > outb_p(HST_CNTL2_KILL, SMB_HST_CNTL2); > data = inb_p(SMB_HST_STS); Reviewed-by: Jean Delvare <jdelvare@suse.de>
diff --git a/drivers/i2c/busses/i2c-ali1563.c b/drivers/i2c/busses/i2c-ali1563.c index 307fb0666ecb..63897a89bb35 100644 --- a/drivers/i2c/busses/i2c-ali1563.c +++ b/drivers/i2c/busses/i2c-ali1563.c @@ -99,7 +99,6 @@ static int ali1563_transaction(struct i2c_adapter *a, int size) return 0; if (!timeout) { - dev_err(&a->dev, "Timeout - Trying to KILL transaction!\n"); /* Issue 'kill' to host controller */ outb_p(HST_CNTL2_KILL, SMB_HST_CNTL2); data = inb_p(SMB_HST_STS);
I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/i2c/busses/i2c-ali1563.c | 1 - 1 file changed, 1 deletion(-)