| Message ID | 20161025143831.14482-1-lersek@redhat.com |
|---|---|
| State | Accepted |
| Commit | 6c9616083c1458ddc0c33ce5415d5f3c0e3c6eee |
| Headers | show |
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> On 2016-10-25 07:38:31, Laszlo Ersek wrote: > XenConsoleSerialPortLib is a BASE type library instance, without being > restricted to UEFI client modules. (For example, the > "ArmVirtPkg/ArmVirtXen.dsc" platform builds this library instance into > "ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf", which is a SEC type > module.) For such library instances, including <Uefi/UefiBaseType.h> is > not right. > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Cc: Jordan Justen <jordan.l.justen@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek <lersek@redhat.com> > --- > OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c b/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c > index 295696312413..4a63b860476d 100644 > --- a/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c > +++ b/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c > @@ -15,7 +15,6 @@ > **/ > > #include <Base.h> > -#include <Uefi/UefiBaseType.h> > > #include <Library/BaseLib.h> > #include <Library/SerialPortLib.h> > -- > 2.9.2 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On 10/25/16 18:46, Jordan Justen wrote: > Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> Thank you, commit 6c9616083c14. Cheers Laszlo > On 2016-10-25 07:38:31, Laszlo Ersek wrote: >> XenConsoleSerialPortLib is a BASE type library instance, without being >> restricted to UEFI client modules. (For example, the >> "ArmVirtPkg/ArmVirtXen.dsc" platform builds this library instance into >> "ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf", which is a SEC type >> module.) For such library instances, including <Uefi/UefiBaseType.h> is >> not right. >> >> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> Cc: Jordan Justen <jordan.l.justen@intel.com> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Laszlo Ersek <lersek@redhat.com> >> --- >> OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c b/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c >> index 295696312413..4a63b860476d 100644 >> --- a/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c >> +++ b/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c >> @@ -15,7 +15,6 @@ >> **/ >> >> #include <Base.h> >> -#include <Uefi/UefiBaseType.h> >> >> #include <Library/BaseLib.h> >> #include <Library/SerialPortLib.h> >> -- >> 2.9.2 >> > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c b/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c index 295696312413..4a63b860476d 100644 --- a/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c +++ b/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c @@ -15,7 +15,6 @@ **/ #include <Base.h> -#include <Uefi/UefiBaseType.h> #include <Library/BaseLib.h> #include <Library/SerialPortLib.h>
XenConsoleSerialPortLib is a BASE type library instance, without being restricted to UEFI client modules. (For example, the "ArmVirtPkg/ArmVirtXen.dsc" platform builds this library instance into "ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf", which is a SEC type module.) For such library instances, including <Uefi/UefiBaseType.h> is not right. Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Jordan Justen <jordan.l.justen@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <lersek@redhat.com> --- OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c | 1 - 1 file changed, 1 deletion(-) -- 2.9.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel