| Message ID | 1477415736-11265-5-git-send-email-ard.biesheuvel@linaro.org |
|---|---|
| State | Accepted |
| Commit | 2e6aa9b51a3b60dd6419144a022beac91723768a |
| Headers | show |
On Tue, Oct 25, 2016 at 06:15:35PM +0100, Ard Biesheuvel wrote: > Use the generic BDS instead of the Intel one. They should be mostly > identical in terms of base functionality, but the generic one will > be kept free of x86 specific legacy. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> \o/ Unless Ryan (or Evan) screams: Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > --- > Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc | 8 +++++++- > Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf | 3 ++- > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc > index 1a0fba9e6e2a..b56e2885ac31 100644 > --- a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc > +++ b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc > @@ -293,4 +293,10 @@ > MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > - IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf > + MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > + MdeModulePkg/Application/UiApp/UiApp.inf { > + <LibraryClasses> > + NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf > + NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf > + NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf > + } > diff --git a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf > index 76c924958b0e..7f4f786644db 100644 > --- a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf > +++ b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf > @@ -172,7 +172,8 @@ FvNameGuid = 73dcb643-3862-4904-9076-a94af1890243 > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > - INF IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf > + INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > + INF MdeModulePkg/Application/UiApp/UiApp.inf > > # > # TianoCore logo (splash screen) > -- > 2.7.4 >
I don't know of any problem with this, and the change seems beneficial, so fine with us. Evan >-----Original Message----- >From: Leif Lindholm [mailto:leif.lindholm@linaro.org] >Sent: 25 October 2016 18:54 >To: ard.biesheuvel@linaro.org >Cc: linaro-uefi@lists.linaro.org; ryan.harkin@linaro.org; Evan Lloyd >Subject: Re: [PATCH 4/5] Platforms/ARM/ArmVExpress-CTA15-A7: switch to >generic BDS > >On Tue, Oct 25, 2016 at 06:15:35PM +0100, Ard Biesheuvel wrote: >> Use the generic BDS instead of the Intel one. They should be mostly >> identical in terms of base functionality, but the generic one will >> be kept free of x86 specific legacy. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > >\o/ > >Unless Ryan (or Evan) screams: >Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > >> --- >> Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc | 8 +++++++- >> Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf | 3 ++- >> 2 files changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc >b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc >> index 1a0fba9e6e2a..b56e2885ac31 100644 >> --- a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc >> +++ b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc >> @@ -293,4 +293,10 @@ >> MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >> MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf >> MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >> - IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf >> + MdeModulePkg/Universal/BdsDxe/BdsDxe.inf >> + MdeModulePkg/Application/UiApp/UiApp.inf { >> + <LibraryClasses> >> + >NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.in >f >> + >NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf >> + >NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaint >enanceManagerUiLib.inf >> + } >> diff --git a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf >b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf >> index 76c924958b0e..7f4f786644db 100644 >> --- a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf >> +++ b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf >> @@ -172,7 +172,8 @@ FvNameGuid = 73dcb643-3862-4904-9076- >a94af1890243 >> INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >> INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf >> INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >> - INF IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf >> + INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf >> + INF MdeModulePkg/Application/UiApp/UiApp.inf >> >> # >> # TianoCore logo (splash screen) >> -- >> 2.7.4 >> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
On 26 October 2016 at 10:59, Evan Lloyd <Evan.Lloyd@arm.com> wrote: > I don't know of any problem with this, and the change seems beneficial, so fine with us. > > Evan > >>-----Original Message----- >>From: Leif Lindholm [mailto:leif.lindholm@linaro.org] >>Sent: 25 October 2016 18:54 >>To: ard.biesheuvel@linaro.org >>Cc: linaro-uefi@lists.linaro.org; ryan.harkin@linaro.org; Evan Lloyd >>Subject: Re: [PATCH 4/5] Platforms/ARM/ArmVExpress-CTA15-A7: switch to >>generic BDS >> >>On Tue, Oct 25, 2016 at 06:15:35PM +0100, Ard Biesheuvel wrote: >>> Use the generic BDS instead of the Intel one. They should be mostly >>> identical in terms of base functionality, but the generic one will >>> be kept free of x86 specific legacy. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> >>\o/ >> >>Unless Ryan (or Evan) screams: >>Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> I'll test the series today, but I'm happy to see it go in if it works! I expect it will work just fine. >> >>> --- >>> Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc | 8 +++++++- >>> Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf | 3 ++- >>> 2 files changed, 9 insertions(+), 2 deletions(-) >>> >>> diff --git a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc >>b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc >>> index 1a0fba9e6e2a..b56e2885ac31 100644 >>> --- a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc >>> +++ b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc >>> @@ -293,4 +293,10 @@ >>> MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >>> MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf >>> MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >>> - IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf >>> + MdeModulePkg/Universal/BdsDxe/BdsDxe.inf >>> + MdeModulePkg/Application/UiApp/UiApp.inf { >>> + <LibraryClasses> >>> + >>NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.in >>f >>> + >>NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf >>> + >>NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaint >>enanceManagerUiLib.inf >>> + } >>> diff --git a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf >>b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf >>> index 76c924958b0e..7f4f786644db 100644 >>> --- a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf >>> +++ b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf >>> @@ -172,7 +172,8 @@ FvNameGuid = 73dcb643-3862-4904-9076- >>a94af1890243 >>> INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >>> INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf >>> INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf >>> - INF IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf >>> + INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf >>> + INF MdeModulePkg/Application/UiApp/UiApp.inf >>> >>> # >>> # TianoCore logo (splash screen) >>> -- >>> 2.7.4 >>> > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. >
diff --git a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc index 1a0fba9e6e2a..b56e2885ac31 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc +++ b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc @@ -293,4 +293,10 @@ MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf - IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf + MdeModulePkg/Universal/BdsDxe/BdsDxe.inf + MdeModulePkg/Application/UiApp/UiApp.inf { + <LibraryClasses> + NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf + NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf + NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf + } diff --git a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf index 76c924958b0e..7f4f786644db 100644 --- a/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf +++ b/Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf @@ -172,7 +172,8 @@ FvNameGuid = 73dcb643-3862-4904-9076-a94af1890243 INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf - INF IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf + INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf + INF MdeModulePkg/Application/UiApp/UiApp.inf # # TianoCore logo (splash screen)
Use the generic BDS instead of the Intel one. They should be mostly identical in terms of base functionality, but the generic one will be kept free of x86 specific legacy. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc | 8 +++++++- Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf | 3 ++- 2 files changed, 9 insertions(+), 2 deletions(-)