diff mbox series

qla2xxx: Fix debugfs output for fw_resource_count

Message ID 20240426020056.3639406-1-himanshu.madhani@oracle.com
State New
Headers show
Series qla2xxx: Fix debugfs output for fw_resource_count | expand

Commit Message

Himanshu Madhani April 26, 2024, 2 a.m. UTC 
From: Himanshu Madhani <himanshu.madhani@oracle.com>

DebugFS output for fw_resource_count shows:

estimate exchange used[0] high water limit [1945] n        estimate iocb2 used [0] high water limit [5141]
        estimate exchange2 used[0] high water limit [1945]

Which shows incorrect display due to missing newline in seq_print().

Fixes: 5f63a163ed2f1 ("scsi: qla2xxx: Fix exchange oversubscription for management commands")
Signed-off-by: Himanshu Madhani <himanshu.madhani@oracle.com>
---
 drivers/scsi/qla2xxx/qla_dfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin K. Petersen May 7, 2024, 1:28 a.m. UTC | #1 
Himanshu,

> DebugFS output for fw_resource_count shows:
>
> estimate exchange used[0] high water limit [1945] n        estimate iocb2 used [0] high water limit [5141]
>         estimate exchange2 used[0] high water limit [1945]
>
> Which shows incorrect display due to missing newline in seq_print().

Applied to 6.10/scsi-staging, thanks!
Martin K. Petersen May 11, 2024, 6:39 p.m. UTC | #2 
On Fri, 26 Apr 2024 02:00:56 +0000, himanshu.madhani@oracle.com wrote:

> DebugFS output for fw_resource_count shows:
> 
> estimate exchange used[0] high water limit [1945] n        estimate iocb2 used [0] high water limit [5141]
>         estimate exchange2 used[0] high water limit [1945]
> 
> Which shows incorrect display due to missing newline in seq_print().
> 
> [...]

Applied to 6.10/scsi-queue, thanks!

[1/1] qla2xxx: Fix debugfs output for fw_resource_count
      https://git.kernel.org/mkp/scsi/c/998d09c5ef61
diff mbox series

Patch

diff --git a/drivers/scsi/qla2xxx/qla_dfs.c b/drivers/scsi/qla2xxx/qla_dfs.c
index 55ff3d7482b3..7375d00fe30f 100644
--- a/drivers/scsi/qla2xxx/qla_dfs.c
+++ b/drivers/scsi/qla2xxx/qla_dfs.c
@@ -274,7 +274,7 @@  qla_dfs_fw_resource_cnt_show(struct seq_file *s, void *unused)
 		seq_printf(s, "Driver: estimate iocb used [%d] high water limit [%d]\n",
 			   iocbs_used, ha->base_qpair->fwres.iocbs_limit);
 
-		seq_printf(s, "estimate exchange used[%d] high water limit [%d] n",
+		seq_printf(s, "estimate exchange used[%d] high water limit [%d] \n",
 			   exch_used, ha->base_qpair->fwres.exch_limit);
 
 		if (ql2xenforce_iocb_limit == 2) {