| Message ID | 20240514131038.28036-1-quic_kbajaj@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: qdu/qru1000-idp: Fix the voltage setting | expand |
On 14/05/2024 15:10, Komal Bajaj wrote: > Fixing the regulator voltages for qdu/qru1000 idp boards. > In particular - > - smps4 is 1.574V min and 2.04V max > - smps5 is 1.2V min and 1.4V max > - smps6 is 0.382V min and 1.12V max Wait, why? This looks, at least partially, you are changing from fixed voltage choice to full range, without clear explanation. > - smps8 is fixed at 0.752V > > Fixes: d1f2cfe2f669 ("arm64: dts: qcom: Add base QDU1000/QRU1000 IDP DTs") > Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> Best regards, Krzysztof
On 5/14/2024 6:57 PM, Krzysztof Kozlowski wrote: > On 14/05/2024 15:10, Komal Bajaj wrote: >> Fixing the regulator voltages for qdu/qru1000 idp boards. >> In particular - >> - smps4 is 1.574V min and 2.04V max >> - smps5 is 1.2V min and 1.4V max >> - smps6 is 0.382V min and 1.12V max > > Wait, why? This looks, at least partially, you are changing from fixed > voltage choice to full range, without clear explanation. > When we started using one of these regulators for USB enablement as sent in the patch series [1], we saw a sudden reboot. After adding more debug logs, came to know the configuration for smps5 was incorrect. Therefore, cross verified the configurations for all the regulators and got to know that these are incorrectly configured. This fixes some manual errors introduced in the initial patch (mentioned in fixes tag). [1] https://lore.kernel.org/linux-arm-msm/20240502090326.21489-1-quic_kbajaj@quicinc.com/ Thanks, Komal. >> - smps8 is fixed at 0.752V > > >> >> Fixes: d1f2cfe2f669 ("arm64: dts: qcom: Add base QDU1000/QRU1000 IDP DTs") >> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> > > Best regards, > Krzysztof >
On 16/05/2024 07:52, Komal Bajaj wrote: > > > On 5/14/2024 6:57 PM, Krzysztof Kozlowski wrote: >> On 14/05/2024 15:10, Komal Bajaj wrote: >>> Fixing the regulator voltages for qdu/qru1000 idp boards. >>> In particular - >>> - smps4 is 1.574V min and 2.04V max >>> - smps5 is 1.2V min and 1.4V max >>> - smps6 is 0.382V min and 1.12V max >> >> Wait, why? This looks, at least partially, you are changing from fixed >> voltage choice to full range, without clear explanation. >> > > When we started using one of these regulators for USB enablement as sent > in the patch series [1], we saw a sudden reboot. > After adding more debug logs, came to know the configuration for smps5 > was incorrect. > > Therefore, cross verified the configurations for all the regulators and > got to know that these are incorrectly configured. > This fixes some manual errors introduced in the initial patch (mentioned > in fixes tag). > > [1] > https://lore.kernel.org/linux-arm-msm/20240502090326.21489-1-quic_kbajaj@quicinc.com/ All this should be explained in commit msg. Best regards, Krzysztof
On 5/17/2024 2:20 PM, Krzysztof Kozlowski wrote: > On 16/05/2024 07:52, Komal Bajaj wrote: >> >> >> On 5/14/2024 6:57 PM, Krzysztof Kozlowski wrote: >>> On 14/05/2024 15:10, Komal Bajaj wrote: >>>> Fixing the regulator voltages for qdu/qru1000 idp boards. >>>> In particular - >>>> - smps4 is 1.574V min and 2.04V max >>>> - smps5 is 1.2V min and 1.4V max >>>> - smps6 is 0.382V min and 1.12V max >>> >>> Wait, why? This looks, at least partially, you are changing from fixed >>> voltage choice to full range, without clear explanation. >>> >> >> When we started using one of these regulators for USB enablement as sent >> in the patch series [1], we saw a sudden reboot. >> After adding more debug logs, came to know the configuration for smps5 >> was incorrect. >> >> Therefore, cross verified the configurations for all the regulators and >> got to know that these are incorrectly configured. >> This fixes some manual errors introduced in the initial patch (mentioned >> in fixes tag). >> >> [1] >> https://lore.kernel.org/linux-arm-msm/20240502090326.21489-1-quic_kbajaj@quicinc.com/ > > All this should be explained in commit msg. Got it. Will add all this info into the commit message of the next version. Thanks Komal > > Best regards, > Krzysztof > >
diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts index 6e129dc123ed..89b84fb0f70a 100644 --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts @@ -96,20 +96,20 @@ vreg_s3a_1p05: smps3 { vreg_s4a_1p8: smps4 { regulator-name = "vreg_s4a_1p8"; - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <1800000>; + regulator-min-microvolt = <1574000>; + regulator-max-microvolt = <2040000>; }; vreg_s5a_2p0: smps5 { regulator-name = "vreg_s5a_2p0"; - regulator-min-microvolt = <1904000>; - regulator-max-microvolt = <2000000>; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1400000>; }; vreg_s6a_0p9: smps6 { regulator-name = "vreg_s6a_0p9"; - regulator-min-microvolt = <920000>; - regulator-max-microvolt = <1128000>; + regulator-min-microvolt = <382000>; + regulator-max-microvolt = <1120000>; }; vreg_s7a_1p2: smps7 { @@ -120,8 +120,8 @@ vreg_s7a_1p2: smps7 { vreg_s8a_1p3: smps8 { regulator-name = "vreg_s8a_1p3"; - regulator-min-microvolt = <1352000>; - regulator-max-microvolt = <1352000>; + regulator-min-microvolt = <752000>; + regulator-max-microvolt = <752000>; }; vreg_l1a_0p91: ldo1 { diff --git a/arch/arm64/boot/dts/qcom/qru1000-idp.dts b/arch/arm64/boot/dts/qcom/qru1000-idp.dts index 2a862c83309e..258483af065b 100644 --- a/arch/arm64/boot/dts/qcom/qru1000-idp.dts +++ b/arch/arm64/boot/dts/qcom/qru1000-idp.dts @@ -96,20 +96,20 @@ vreg_s3a_1p05: smps3 { vreg_s4a_1p8: smps4 { regulator-name = "vreg_s4a_1p8"; - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <1800000>; + regulator-min-microvolt = <1574000>; + regulator-max-microvolt = <2040000>; }; vreg_s5a_2p0: smps5 { regulator-name = "vreg_s5a_2p0"; - regulator-min-microvolt = <1904000>; - regulator-max-microvolt = <2000000>; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1400000>; }; vreg_s6a_0p9: smps6 { regulator-name = "vreg_s6a_0p9"; - regulator-min-microvolt = <920000>; - regulator-max-microvolt = <1128000>; + regulator-min-microvolt = <382000>; + regulator-max-microvolt = <1120000>; }; vreg_s7a_1p2: smps7 { @@ -120,8 +120,8 @@ vreg_s7a_1p2: smps7 { vreg_s8a_1p3: smps8 { regulator-name = "vreg_s8a_1p3"; - regulator-min-microvolt = <1352000>; - regulator-max-microvolt = <1352000>; + regulator-min-microvolt = <752000>; + regulator-max-microvolt = <752000>; }; vreg_l1a_0p91: ldo1 {
Fixing the regulator voltages for qdu/qru1000 idp boards. In particular - - smps4 is 1.574V min and 2.04V max - smps5 is 1.2V min and 1.4V max - smps6 is 0.382V min and 1.12V max - smps8 is fixed at 0.752V Fixes: d1f2cfe2f669 ("arm64: dts: qcom: Add base QDU1000/QRU1000 IDP DTs") Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> --- arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 16 ++++++++-------- arch/arm64/boot/dts/qcom/qru1000-idp.dts | 16 ++++++++-------- 2 files changed, 16 insertions(+), 16 deletions(-) -- 2.42.0