[v5,27/68] selftests/lsm: Drop define _GNU_SOURCE

Message ID	20240522005913.3540131-28-edliaw@google.com
State	New
Headers	show Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 129FF14A63D for <linux-kselftest@vger.kernel.org>; Wed, 22 May 2024 01:00:46 +0000 (UTC) Date: Wed, 22 May 2024 00:57:13 +0000 In-Reply-To: <20240522005913.3540131-1-edliaw@google.com> Precedence: bulk Mime-Version: 1.0 References: <20240522005913.3540131-1-edliaw@google.com> Message-ID: <20240522005913.3540131-28-edliaw@google.com> Subject: [PATCH v5 27/68] selftests/lsm: Drop define _GNU_SOURCE From: Edward Liaw <edliaw@google.com> To: shuah@kernel.org, " =?utf-8?q?Micka=C3=ABl_Sala=C3=BCn?= " <mic@digikod.net>, " =?utf-8?q?G?= =?utf-8?q?=C3=BCnther_Noack?= " <gnoack@google.com>, Christian Brauner <brauner@kernel.org>, Richard Cochran <richardcochran@gmail.com>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Jesper Dangaard Brouer <hawk@kernel.org>, John Fastabend <john.fastabend@gmail.com>, Paul Moore <paul@paul-moore.com>, James Morris <jmorris@namei.org>, "Serge E. Hallyn" <serge@hallyn.com> Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, Edward Liaw <edliaw@google.com>, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org, John Hubbard <jhubbard@nvidia.com>, Muhammad Usama Anjum <usama.anjum@collabora.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Series	Define _GNU_SOURCE for sources using \| expand [v5,00/68] Define _GNU_SOURCE for sources using [v5,01/68] selftests: Compile with -D_GNU_SOURCE when including lib.mk [v5,02/68] kselftest: Desecalate reporting of missing _GNU_SOURCE [v5,03/68] selftests/arm64: Drop define _GNU_SOURCE [v5,04/68] selftests/arm64: Drop duplicate -D_GNU_SOURCE [v5,05/68] selftests/bpf: Drop define _GNU_SOURCE [v5,06/68] selftests/breakpoints: Drop define _GNU_SOURCE [v5,07/68] selftests/cachestat: Drop define _GNU_SOURCE [v5,08/68] selftests/capabilities: Drop define _GNU_SOURCE [v5,09/68] selftests/cgroup: Drop define _GNU_SOURCE [v5,10/68] selftests/clone3: Drop define _GNU_SOURCE [v5,11/68] selftests/core: Drop define _GNU_SOURCE [v5,12/68] selftests/damon: Drop define _GNU_SOURCE [v5,13/68] selftests/drivers: Drop define _GNU_SOURCE [v5,14/68] selftests/exec: Drop duplicate -D_GNU_SOURCE [v5,15/68] selftests/fchmodat2: Drop define _GNU_SOURCE [v5,16/68] selftests/filelock: Drop define _GNU_SOURCE [v5,17/68] selftests/filesystems: Drop define _GNU_SOURCE [v5,18/68] selftests/firmware: Drop define _GNU_SOURCE [v5,19/68] selftests/fpu: Drop define _GNU_SOURCE [v5,20/68] selftests/futex: Drop define _GNU_SOURCE [v5,21/68] selftests/futex: Drop duplicate -D_GNU_SOURCE [v5,22/68] selftests/intel_pstate: Drop duplicate -D_GNU_SOURCE [v5,23/68] selftests/iommu: Drop duplicate -D_GNU_SOURCE [v5,24/68] selftests/ipc: Drop define _GNU_SOURCE [v5,25/68] selftests/kcmp: Drop define _GNU_SOURCE [v5,26/68] selftests/landlock: Drop define _GNU_SOURCE [v5,27/68] selftests/lsm: Drop define _GNU_SOURCE [v5,28/68] selftests/membarrier: Drop define _GNU_SOURCE [v5,29/68] selftests/memfd: Drop define _GNU_SOURCE [v5,30/68] selftests/mincore: Drop define _GNU_SOURCE [v5,31/68] selftests/mm: Drop define _GNU_SOURCE [v5,32/68] selftests/mount: Drop define _GNU_SOURCE [v5,33/68] selftests/mount_setattr: Drop define _GNU_SOURCE [v5,34/68] selftests/move_mount_set_group: Drop define _GNU_SOURCE [v5,35/68] selftests/mqueue: Drop define _GNU_SOURCE [v5,36/68] selftests/net: Drop define _GNU_SOURCE [v5,37/68] selftests/net: Drop duplicate -D_GNU_SOURCE [v5,38/68] selftests/nsfs: Drop define _GNU_SOURCE [v5,39/68] selftests/openat2: Drop define _GNU_SOURCE [v5,40/68] selftests/perf_events: Drop define _GNU_SOURCE [v5,41/68] selftests/pid_namespace: Drop define _GNU_SOURCE [v5,42/68] selftests/pidfd: Drop define _GNU_SOURCE [v5,43/68] selftests/ptrace: Drop define _GNU_SOURCE [v5,44/68] selftests/powerpc: Drop define _GNU_SOURCE [v5,45/68] selftests/proc: Drop define _GNU_SOURCE [v5,46/68] selftests/proc: Drop duplicate -D_GNU_SOURCE [v5,47/68] selftests/ptp: Drop define _GNU_SOURCE [v5,48/68] selftests/resctrl: Drop duplicate -D_GNU_SOURCE [v5,49/68] selftests/riscv: Drop define _GNU_SOURCE [v5,50/68] selftests/riscv: Drop duplicate -D_GNU_SOURCE [v5,51/68] selftests/rlimits: Drop define _GNU_SOURCE [v5,52/68] selftests/rseq: Drop define _GNU_SOURCE [v5,53/68] selftests/safesetid: Drop define _GNU_SOURCE [v5,54/68] selftests/sched: Drop define _GNU_SOURCE [v5,55/68] selftests/seccomp: Drop define _GNU_SOURCE [v5,56/68] selftests/sigaltstack: Drop define _GNU_SOURCE [v5,57/68] selftests/sgx: Compile with -D_GNU_SOURCE [v5,58/68] selftests/splice: Drop define _GNU_SOURCE [v5,59/68] selftests/syscall_user_dispatch: Drop define _GNU_SOURCE [v5,60/68] selftests/thermal: Drop define _GNU_SOURCE [v5,61/68] selftests/timens: Drop define _GNU_SOURCE [v5,62/68] selftests/tmpfs: Drop duplicate -D_GNU_SOURCE [v5,63/68] selftests/uevent: Drop define _GNU_SOURCE [v5,64/68] selftests/user_events: Drop define _GNU_SOURCE [v5,65/68] selftests/vDSO: Append to CFLAGS in Makefile [v5,66/68] selftests/vDSO: Drop define _GNU_SOURCE [v5,67/68] selftests/x86: Append to CFLAGS in Makefile [v5,68/68] selftests/x86: Drop define _GNU_SOURCE

Message ID

20240522005913.3540131-28-edliaw@google.com

State

New

Headers

Date: Wed, 22 May 2024 00:57:13 +0000
In-Reply-To: <20240522005913.3540131-1-edliaw@google.com>
Precedence: bulk
Mime-Version: 1.0
References: <20240522005913.3540131-1-edliaw@google.com>
Message-ID: <20240522005913.3540131-28-edliaw@google.com>
Subject: [PATCH v5 27/68] selftests/lsm: Drop define _GNU_SOURCE
From: Edward Liaw <edliaw@google.com>
To: shuah@kernel.org,
 " =?utf-8?q?Micka=C3=ABl_Sala=C3=BCn?= " <mic@digikod.net>,  " =?utf-8?q?G?=
	=?utf-8?q?=C3=BCnther_Noack?= " <gnoack@google.com>,
 Christian Brauner <brauner@kernel.org>,
  Richard Cochran <richardcochran@gmail.com>,
 Paul Walmsley <paul.walmsley@sifive.com>,
  Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
  Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>,
  "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>,
  Jesper Dangaard Brouer <hawk@kernel.org>,
 John Fastabend <john.fastabend@gmail.com>,  Paul Moore <paul@paul-moore.com>,
 James Morris <jmorris@namei.org>,  "Serge E. Hallyn" <serge@hallyn.com>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	kernel-team@android.com, Edward Liaw <edliaw@google.com>,
	linux-security-module@vger.kernel.org, netdev@vger.kernel.org,
	linux-riscv@lists.infradead.org, bpf@vger.kernel.org,
	John Hubbard <jhubbard@nvidia.com>,
 Muhammad Usama Anjum <usama.anjum@collabora.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Series

Define _GNU_SOURCE for sources using | expand

Commit Message

Edward Liaw May 22, 2024, 12:57 a.m. UTC

_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.

Reviewed-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: Edward Liaw <edliaw@google.com>
---
 tools/testing/selftests/lsm/common.c                 | 2 --
 tools/testing/selftests/lsm/lsm_get_self_attr_test.c | 2 --
 tools/testing/selftests/lsm/lsm_list_modules_test.c  | 2 --
 tools/testing/selftests/lsm/lsm_set_self_attr_test.c | 2 --
 4 files changed, 8 deletions(-)

Comments

Casey Schaufler May 22, 2024, 1:37 a.m. UTC | #1

On 5/21/2024 5:57 PM, Edward Liaw wrote:
> _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
> redefinition warnings.
>
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> Signed-off-by: Edward Liaw <edliaw@google.com>

Acked-by: Casey Schaufler <casey@schaufler-ca.com>

> ---
>  tools/testing/selftests/lsm/common.c                 | 2 --
>  tools/testing/selftests/lsm/lsm_get_self_attr_test.c | 2 --
>  tools/testing/selftests/lsm/lsm_list_modules_test.c  | 2 --
>  tools/testing/selftests/lsm/lsm_set_self_attr_test.c | 2 --
>  4 files changed, 8 deletions(-)
>
> diff --git a/tools/testing/selftests/lsm/common.c b/tools/testing/selftests/lsm/common.c
> index 9ad258912646..1b18aac570f1 100644
> --- a/tools/testing/selftests/lsm/common.c
> +++ b/tools/testing/selftests/lsm/common.c
> @@ -4,8 +4,6 @@
>   *
>   * Copyright © 2023 Casey Schaufler <casey@schaufler-ca.com>
>   */
> -
> -#define _GNU_SOURCE
>  #include <linux/lsm.h>
>  #include <fcntl.h>
>  #include <string.h>
> diff --git a/tools/testing/selftests/lsm/lsm_get_self_attr_test.c b/tools/testing/selftests/lsm/lsm_get_self_attr_test.c
> index df215e4aa63f..7465bde3f922 100644
> --- a/tools/testing/selftests/lsm/lsm_get_self_attr_test.c
> +++ b/tools/testing/selftests/lsm/lsm_get_self_attr_test.c
> @@ -5,8 +5,6 @@
>   *
>   * Copyright © 2022 Casey Schaufler <casey@schaufler-ca.com>
>   */
> -
> -#define _GNU_SOURCE
>  #include <linux/lsm.h>
>  #include <fcntl.h>
>  #include <string.h>
> diff --git a/tools/testing/selftests/lsm/lsm_list_modules_test.c b/tools/testing/selftests/lsm/lsm_list_modules_test.c
> index 06d24d4679a6..a6b44e25c21f 100644
> --- a/tools/testing/selftests/lsm/lsm_list_modules_test.c
> +++ b/tools/testing/selftests/lsm/lsm_list_modules_test.c
> @@ -5,8 +5,6 @@
>   *
>   * Copyright © 2022 Casey Schaufler <casey@schaufler-ca.com>
>   */
> -
> -#define _GNU_SOURCE
>  #include <linux/lsm.h>
>  #include <string.h>
>  #include <stdio.h>
> diff --git a/tools/testing/selftests/lsm/lsm_set_self_attr_test.c b/tools/testing/selftests/lsm/lsm_set_self_attr_test.c
> index 66dec47e3ca3..110c6a07e74c 100644
> --- a/tools/testing/selftests/lsm/lsm_set_self_attr_test.c
> +++ b/tools/testing/selftests/lsm/lsm_set_self_attr_test.c
> @@ -5,8 +5,6 @@
>   *
>   * Copyright © 2022 Casey Schaufler <casey@schaufler-ca.com>
>   */
> -
> -#define _GNU_SOURCE
>  #include <linux/lsm.h>
>  #include <string.h>
>  #include <stdio.h>

diff --git a/tools/testing/selftests/lsm/common.c b/tools/testing/selftests/lsm/common.c
index 9ad258912646..1b18aac570f1 100644
--- a/tools/testing/selftests/lsm/common.c
+++ b/tools/testing/selftests/lsm/common.c
@@ -4,8 +4,6 @@ 
  *
  * Copyright © 2023 Casey Schaufler <casey@schaufler-ca.com>
  */
-
-#define _GNU_SOURCE
 #include <linux/lsm.h>
 #include <fcntl.h>
 #include <string.h>
diff --git a/tools/testing/selftests/lsm/lsm_get_self_attr_test.c b/tools/testing/selftests/lsm/lsm_get_self_attr_test.c
index df215e4aa63f..7465bde3f922 100644
--- a/tools/testing/selftests/lsm/lsm_get_self_attr_test.c
+++ b/tools/testing/selftests/lsm/lsm_get_self_attr_test.c
@@ -5,8 +5,6 @@ 
  *
  * Copyright © 2022 Casey Schaufler <casey@schaufler-ca.com>
  */
-
-#define _GNU_SOURCE
 #include <linux/lsm.h>
 #include <fcntl.h>
 #include <string.h>
diff --git a/tools/testing/selftests/lsm/lsm_list_modules_test.c b/tools/testing/selftests/lsm/lsm_list_modules_test.c
index 06d24d4679a6..a6b44e25c21f 100644
--- a/tools/testing/selftests/lsm/lsm_list_modules_test.c
+++ b/tools/testing/selftests/lsm/lsm_list_modules_test.c
@@ -5,8 +5,6 @@ 
  *
  * Copyright © 2022 Casey Schaufler <casey@schaufler-ca.com>
  */
-
-#define _GNU_SOURCE
 #include <linux/lsm.h>
 #include <string.h>
 #include <stdio.h>
diff --git a/tools/testing/selftests/lsm/lsm_set_self_attr_test.c b/tools/testing/selftests/lsm/lsm_set_self_attr_test.c
index 66dec47e3ca3..110c6a07e74c 100644
--- a/tools/testing/selftests/lsm/lsm_set_self_attr_test.c
+++ b/tools/testing/selftests/lsm/lsm_set_self_attr_test.c
@@ -5,8 +5,6 @@ 
  *
  * Copyright © 2022 Casey Schaufler <casey@schaufler-ca.com>
  */
-
-#define _GNU_SOURCE
 #include <linux/lsm.h>
 #include <string.h>
 #include <stdio.h>

[v5,27/68] selftests/lsm: Drop define _GNU_SOURCE

Commit Message

Comments

Patch