| Message ID | 1478183795-740-1-git-send-email-julien.grall@arm.com |
|---|---|
| State | New |
| Headers | show |
On Thu, Nov 03, 2016 at 02:36:35PM +0000, Julien Grall wrote: > The variable debug is used to enable debug for the tools. As > early-printk is for the hypervisor we should use CONFIG_DEBUG. > > Signed-off-by: Julien Grall <julien.grall@arm.com> > Acked-by: Wei Liu <wei.liu2@citrix.com> Sorry I missed this.
diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk index 93304be..569a0ba 100644 --- a/xen/arch/arm/Rules.mk +++ b/xen/arch/arm/Rules.mk @@ -24,7 +24,7 @@ endif EARLY_PRINTK := n -ifeq ($(debug),y) +ifeq ($(CONFIG_DEBUG),y) # See docs/misc/arm/early-printk.txt for syntax @@ -77,7 +77,7 @@ CFLAGS-$(EARLY_PRINTK) += -DEARLY_PRINTK_BAUD=$(EARLY_PRINTK_BAUD) CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_BASE_ADDRESS=$(EARLY_UART_BASE_ADDRESS) CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_REG_SHIFT=$(EARLY_UART_REG_SHIFT) -else # !debug +else # !CONFIG_DEBUG ifneq ($(CONFIG_EARLY_PRINTK),) # Early printk is dependant on a debug build.
The variable debug is used to enable debug for the tools. As early-printk is for the hypervisor we should use CONFIG_DEBUG. Signed-off-by: Julien Grall <julien.grall@arm.com> --- This patch is candidate for Xen 4.8. This is a follow-up of [1]. [1] https://lists.xenproject.org/archives/html/xen-devel/2016-11/msg00082.html --- xen/arch/arm/Rules.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)