diff mbox

[oe,meta-oe,1/2] krb5: Add -fPIC to compile flags

Message ID 20161103173342.13661-1-raj.khem@gmail.com
State Superseded
Headers show

Commit Message

Khem Raj Nov. 3, 2016, 5:33 p.m. UTC
Fixes errors on x86_64 e.g.
errors.so: relocation R_X86_64_PC32 against symbol `k5_vset_error' can not be used when making a shared object; recompile with -fPIC

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 meta-oe/recipes-connectivity/krb5/krb5_1.13.6.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.10.2

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Comments

André Draszik Nov. 3, 2016, 9:26 p.m. UTC | #1
On Thu, 2016-11-03 at 10:33 -0700, Khem Raj wrote:
> Fixes errors on x86_64 e.g.
> errors.so: relocation R_X86_64_PC32 against symbol `k5_vset_error' can not
> be used when making a shared object; recompile with -fPIC
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta-oe/recipes-connectivity/krb5/krb5_1.13.6.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-oe/recipes-connectivity/krb5/krb5_1.13.6.bb b/meta-
> oe/recipes-connectivity/krb5/krb5_1.13.6.bb
> index e2d0594..06f7f90 100644
> --- a/meta-oe/recipes-connectivity/krb5/krb5_1.13.6.bb
> +++ b/meta-oe/recipes-connectivity/krb5/krb5_1.13.6.bb
> @@ -51,8 +51,8 @@ CACHED_CONFIGUREVARS +=
> "krb5_cv_attr_constructor_destructor=yes ac_cv_func_regc
>                    ac_cv_printf_positional=yes
> ac_cv_file__etc_environment=yes \
>                    ac_cv_file__etc_TIMEZONE=no"
>  
> -CFLAGS_append = " -DDESTRUCTOR_ATTR_WORKS=1 -I${STAGING_INCDIR}/et"
> -LDFLAGS_append = " -lpthread"
> +CFLAGS_append = " -fPIC -DDESTRUCTOR_ATTR_WORKS=1 -I${STAGING_INCDIR}/et"
> +LDFLAGS_append = " -pthread"

Hm, it would be useful to add -pthread to CFLAGS as well in this case. That
flag is doing more than just adding the library to the linker command line,
see gcc -dumpspecs

Cheers,
Andre'

>  
>  FILES_${PN} += "${datadir}/gnats"
>  FILES_${PN}-doc += "${datadir}/examples"
> -- 
> 2.10.2
>
diff mbox

Patch

diff --git a/meta-oe/recipes-connectivity/krb5/krb5_1.13.6.bb b/meta-oe/recipes-connectivity/krb5/krb5_1.13.6.bb
index e2d0594..06f7f90 100644
--- a/meta-oe/recipes-connectivity/krb5/krb5_1.13.6.bb
+++ b/meta-oe/recipes-connectivity/krb5/krb5_1.13.6.bb
@@ -51,8 +51,8 @@  CACHED_CONFIGUREVARS += "krb5_cv_attr_constructor_destructor=yes ac_cv_func_regc
                   ac_cv_printf_positional=yes ac_cv_file__etc_environment=yes \
                   ac_cv_file__etc_TIMEZONE=no"
 
-CFLAGS_append = " -DDESTRUCTOR_ATTR_WORKS=1 -I${STAGING_INCDIR}/et"
-LDFLAGS_append = " -lpthread"
+CFLAGS_append = " -fPIC -DDESTRUCTOR_ATTR_WORKS=1 -I${STAGING_INCDIR}/et"
+LDFLAGS_append = " -pthread"
 
 FILES_${PN} += "${datadir}/gnats"
 FILES_${PN}-doc += "${datadir}/examples"