| Message ID | 20240627-k1-01-basic-dt-v2-3-cc06c7555f07@gentoo.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | riscv: add initial support for SpacemiT K1 | expand |
On Thu, 27 Jun 2024 15:31:17 +0000, Yixun Lan wrote: > From: Yangyu Chen <cyy@cyyself.name> > > Add DT binding documentation for the SpacemiT K1 Soc[1] and the Banana > Pi BPi-F3 board[2] which used it. > > [1] https://www.spacemit.com/en/spacemit-key-stone-2/ > [2] https://docs.banana-pi.org/en/BPI-F3/BananaPi_BPI-F3 > > Signed-off-by: Yangyu Chen <cyy@cyyself.name> > Signed-off-by: Yixun Lan <dlan@gentoo.org> > --- > .../devicetree/bindings/riscv/spacemit.yaml | 24 ++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/spacemit.yaml: 'maintainers' is a required property hint: Metaschema for devicetree binding documentation from schema $id: http://devicetree.org/meta-schemas/base.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240627-k1-01-basic-dt-v2-3-cc06c7555f07@gentoo.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 27/06/2024 17:31, Yixun Lan wrote: > From: Yangyu Chen <cyy@cyyself.name> > > Add DT binding documentation for the SpacemiT K1 Soc[1] and the Banana > Pi BPi-F3 board[2] which used it. > > [1] https://www.spacemit.com/en/spacemit-key-stone-2/ > [2] https://docs.banana-pi.org/en/BPI-F3/BananaPi_BPI-F3 You got a bug reported by tool and you send the same version again, producing the same bug. In case it is not clear: *You cannot ignore* bug reports, comments, reviewer requests or any other reply to your patchset. Each one must be addressed one way or another. Best regards, Krzysztof
On 09:34 Fri 28 Jun , Krzysztof Kozlowski wrote: > On 27/06/2024 17:31, Yixun Lan wrote: > > From: Yangyu Chen <cyy@cyyself.name> > > > > Add DT binding documentation for the SpacemiT K1 Soc[1] and the Banana > > Pi BPi-F3 board[2] which used it. > > > > [1] https://www.spacemit.com/en/spacemit-key-stone-2/ > > [2] https://docs.banana-pi.org/en/BPI-F3/BananaPi_BPI-F3 > > You got a bug reported by tool and you send the same version again, > producing the same bug. > > In case it is not clear: > > *You cannot ignore* bug reports, comments, reviewer requests or any > other reply to your patchset. Each one must be addressed one way or another. > sorry, it's my fault, I rushed to send out this series. and yes, I should really go back and check all the thread.. I will fix all the issues in next version (tags, dt error..)
diff --git a/Documentation/devicetree/bindings/riscv/spacemit.yaml b/Documentation/devicetree/bindings/riscv/spacemit.yaml new file mode 100644 index 0000000000000..3b151fd02473e --- /dev/null +++ b/Documentation/devicetree/bindings/riscv/spacemit.yaml @@ -0,0 +1,24 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/riscv/spacemit.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: SpacemiT SoC-based boards + +description: + SpacemiT SoC-based boards + +properties: + $nodename: + const: '/' + compatible: + oneOf: + - items: + - enum: + - bananapi,bpi-f3 + - const: spacemit,k1 + +additionalProperties: true + +...